chore: replace non-ASCII characters in api_description#12795
chore: replace non-ASCII characters in api_description#12795
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces non-ASCII characters with ASCII equivalents in the generation_config.yaml file. However, the changes also include the deletion of two .repo-metadata.json files, which appears to be unintended. Feedback suggests restoring these files and updating their content to use ASCII characters instead of removing them entirely to preserve essential metadata.
I am having trouble creating individual review comments. Click here to see my feedback.
java-databasecenter/.repo-metadata.json (1-16)
The removal of this metadata file appears to be unintended. The pull request's stated objective is to replace non-ASCII characters, but this change deletes the entire file, which contains essential metadata such as distribution_name and api_id that is not present in the generation_config.yaml snippet. Instead of deleting the file, the api_description field should be updated to use ASCII characters.
{
"api_shortname": "databasecenter",
"name_pretty": "Database Center API",
"product_documentation": "https://cloud.google.com/database-center/docs/overview",
"api_description": "Database Center provides an organization-wide, cross-product fleet health platform to eliminate the overhead, complexity, and risk associated with aggregating and summarizing health signals through custom dashboards. Through Database Center's fleet health dashboard and API, database platform teams that are responsible for reliability, compliance, security, cost, and administration of database fleets will now have a single pane of glass that pinpoints issues relevant to each team.",
"client_documentation": "https://cloud.google.com/java/docs/reference/google-cloud-databasecenter/latest/overview",
"release_level": "preview",
"transport": "both",
"language": "java",
"repo": "googleapis/google-cloud-java",
"repo_short": "java-databasecenter",
"distribution_name": "com.google.cloud:google-cloud-databasecenter",
"api_id": "databasecenter.googleapis.com",
"library_type": "GAPIC_AUTO",
"requires_billing": true
}
java-webrisk/.repo-metadata.json (1-18)
Similar to the other metadata file, this deletion seems unintended. This file contains important metadata and a more complete api_description than what is currently shown in the generation_config.yaml diff. Please update the file to use ASCII characters instead of removing it.
{
"api_shortname": "webrisk",
"name_pretty": "Web Risk",
"product_documentation": "https://cloud.google.com/web-risk/docs/",
"api_description": "is a Google Cloud service that lets client applications check URLs against Google's constantly updated lists of unsafe web resources. Unsafe web resources include social engineering sites - such as phishing and deceptive sites - and sites that host malware or unwanted software. With the Web Risk API, you can quickly identify known bad sites, warn users before they click infected links, and prevent users from posting links to known infected pages from your site. The Web Risk API includes data on more than a million unsafe URLs and stays up to date by examining billions of URLs each day.",
"client_documentation": "https://cloud.google.com/java/docs/reference/google-cloud-webrisk/latest/overview",
"release_level": "stable",
"transport": "both",
"language": "java",
"repo": "googleapis/google-cloud-java",
"repo_short": "java-webrisk",
"distribution_name": "com.google.cloud:google-cloud-webrisk",
"api_id": "webrisk.googleapis.com",
"library_type": "GAPIC_AUTO",
"requires_billing": false,
"rest_documentation": "https://cloud.google.com/web-risk/docs/reference/rest",
"rpc_documentation": "https://cloud.google.com/web-risk/docs/reference/rpc"
}
1a081c0 to
fb1d9d4
Compare
Replace non-ASCII characters in api_description.
replaced: U+2019 to U+0027 ('), U+2014 to U+002D (-)
Fix googleapis/librarian#5371