Skip to content

fix: secure URL transcoding path traversal vulnerability in REST fallback #3973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danieljbruce wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix: secure URL transcoding path traversal vulnerability in REST fallback #3973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8294647
fix: secure URL transcoding path traversal vulnerability in REST fall…
google-labs-jules[bot] Aug 14, 2026
f9923ac
linter failings
danieljbruce Aug 17, 2026
6ec9f8e
fix: secure URL transcoding path traversal vulnerability in REST fall…
google-labs-jules[bot] Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
19 changes: 17 additions & 2 deletions src/apis/abusiveexperiencereport/v1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ import {
APIRequestContext,
} from 'googleapis-common';
import {Readable} from 'stream';
import {
validateSingleSegment,
validateMultiSegment,
encodeWithSlashes,
encodeWithoutSlashes,
} from '../../transcoding';

export namespace abusiveexperiencereport_v1 {
export interface Options extends GlobalOptions {
Expand Down Expand Up @@ -289,12 +295,19 @@ export namespace abusiveexperiencereport_v1 {
options = {};
}

if (params.name !== undefined && params.name !== null) {
validateMultiSegment('name', String(params.name));
params.name = encodeWithoutSlashes(String(params.name));
}

const rootUrl =
options.rootUrl || 'https://abusiveexperiencereport.googleapis.com/';
const parameters = {
options: Object.assign(
{
url: (rootUrl + '/v1/{+name}').replace(/([^:]\/)\/+/g, '$1'),
url: (rootUrl + '/v1/{+name}')
.replace(/([^:]\/)\/+/g, '$1')
.replace(/\{([^+:][^}]*)\}/g, '{+$1}'),
method: 'GET',
apiVersion: '',
},
Expand Down Expand Up @@ -441,7 +454,9 @@ export namespace abusiveexperiencereport_v1 {
const parameters = {
options: Object.assign(
{
url: (rootUrl + '/v1/violatingSites').replace(/([^:]\/)\/+/g, '$1'),
url: (rootUrl + '/v1/violatingSites')
.replace(/([^:]\/)\/+/g, '$1')
.replace(/\{([^+:][^}]*)\}/g, '{+$1}'),
method: 'GET',
apiVersion: '',
},
Expand Down
13 changes: 9 additions & 4 deletions src/apis/acceleratedmobilepageurl/v1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ import {
APIRequestContext,
} from 'googleapis-common';
import {Readable} from 'stream';
import {
validateSingleSegment,
validateMultiSegment,
encodeWithSlashes,
encodeWithoutSlashes,
} from '../../transcoding';

export namespace acceleratedmobilepageurl_v1 {
export interface Options extends GlobalOptions {
Expand Down Expand Up @@ -314,10 +320,9 @@ export namespace acceleratedmobilepageurl_v1 {
const parameters = {
options: Object.assign(
{
url: (rootUrl + '/v1/ampUrls:batchGet').replace(
/([^:]\/)\/+/g,
'$1'
),
url: (rootUrl + '/v1/ampUrls:batchGet')
.replace(/([^:]\/)\/+/g, '$1')
.replace(/\{([^+:][^}]*)\}/g, '{+$1}'),
method: 'POST',
apiVersion: '',
},
Expand Down
Loading
Loading