Hoist counter updates out of the CentralFreeList::InsertRange lock. - #724
Closed
copybara-service[bot] wants to merge 1 commit into
Closed
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
num_same_spans_, counter_, and num_spans_returned_ are lock-free StatsCounters updated via LossyAdd; moving their updates past the lock scope narrows the critical section. Single-threaded accuracy is unchanged; under concurrency the counters become best-effort. PiperOrigin-RevId: 980025674
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoist counter updates out of the CentralFreeList::InsertRange lock.
num_same_spans_, counter_, and num_spans_returned_ are lock-free StatsCounters
updated via LossyAdd; moving their updates past the lock scope narrows the
critical section. Single-threaded accuracy is unchanged; under concurrency the
counters become best-effort.