Remove the num_same_spans_ span-return histogram from CentralFreeList. - #720
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Remove the num_same_spans_ span-return histogram from CentralFreeList.#720copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
This telemetry was added under TODO(b/527641380) to characterize how many objects in a returned batch land on the same span, guiding CentralFreeList optimization work. It cost a per-size-class StatsCounter array plus per-batch bookkeeping in the InsertRange hot path (a run counter and a LossyAdd), and exposed the counts through text and pbtxt stats printers. The optimization investigation this instrumentation supported is complete, so delete the histogram, its supporting constant, the InsertRange accounting, the PrintSameSpanStats/PrintSameSpanStatsInPbtxt printers, their callers in global_stats, and the associated tests. PiperOrigin-RevId: 979988245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the num_same_spans_ span-return histogram from CentralFreeList.
This telemetry was added under TODO(b/527641380) to characterize how many
objects in a returned batch land on the same span, guiding CentralFreeList
optimization work. It cost a per-size-class StatsCounter array plus per-batch
bookkeeping in the InsertRange hot path (a run counter and a LossyAdd), and
exposed the counts through text and pbtxt stats printers.
The optimization investigation this instrumentation supported is complete, so
delete the histogram, its supporting constant, the InsertRange accounting, the
PrintSameSpanStats/PrintSameSpanStatsInPbtxt printers, their callers in
global_stats, and the associated tests.