Skip to content

Migrate search.py to request helpers #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
PaperMtn wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Migrate search.py to request helpers #181

PaperMtn wants to merge 6 commits into from

Conversation

@PaperMtn
Copy link
Contributor

@PaperMtn PaperMtn commented Feb 9, 2026

Summary

(contributes towards addressing [#149])

Migrate secops.chronicle.search to use request helpers

  • Request functions in module now implementing helpers in secops.chronicle.utils.request_utils
  • Update tests in test_search.py to only test module logic and not centralised error handling, which is already tested
    • Remove redundant test from test_client.py

@PaperMtn PaperMtn requested a review from mihirvala08 as a code owner February 9, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mihirvala08 mihirvala08 Awaiting requested review from mihirvala08 mihirvala08 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PaperMtn @mihirvala08