Skip to content

Conversation

@jess-lowe
Copy link
Contributor

@jess-lowe jess-lowe commented Feb 1, 2026

This change fixes some nits, introduces a bad repository cache and stops the conversion from discarding versions just because a commit was provided in the references.

  • Removed CVEID from error formatting as at time of logging, CVEID is already provided via slog.
  • Removed warnings from some logs in favour of adding to metrics.Notes file for better investigation later. There may be value in keeping these at warning levels only if we also are prepared to handle investigating spikes, in which case logs should appear closer to what is causing the errors (network requests generally).
  • made errors lowercase as linter demands

michaelkedar
michaelkedar previously approved these changes Feb 2, 2026
@jess-lowe jess-lowe requested a review from another-rex February 2, 2026 00:51
another-rex
another-rex previously approved these changes Feb 2, 2026
@jess-lowe jess-lowe merged commit ee3ce09 into google:master Feb 2, 2026
19 checks passed
@jess-lowe jess-lowe deleted the fix/nvd-nits branch February 2, 2026 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants