Skip to content

Add usecase to get Loi reports#3605

Merged
andreia-ferreira merged 11 commits intomasterfrom
andreia/3575/add-usecase
Mar 11, 2026
Merged

Add usecase to get Loi reports#3605
andreia-ferreira merged 11 commits intomasterfrom
andreia/3575/add-usecase

Conversation

@andreia-ferreira
Copy link
Collaborator

@andreia-ferreira andreia-ferreira commented Mar 10, 2026

Towards #3575

This PR adds the use case to fetch a LoiReport, which will be initially used to hold the geoJson which needs to be displayed later on in the UI by QR code. This doesn't change any functionality, the use case will be implemented in a follow up

Note: LocationOfInterest model should be in the domain module. However, it was not moved at this stage since it still has some dependencies that need a significant refactor (eg. usage of java.util.Date - a dedicated issue has been created for it, since it affects quite a lot of files #3604 )

@shobhitagarwal1612 PTAL?

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on adding the functionality to retrieve a Location of Interest (LOI) report, which includes the geoJson representation of the LOI. This report will be used to display the LOI in the UI using a QR code. The changes involve creating a new Domain Module, refactoring dependencies, and implementing the use case to fetch the LOI report.

Highlights

  • New Feature: This PR introduces the use case to fetch a LoiReport, which will initially hold the geoJson to be displayed in the UI via QR code.
  • Domain Module: A new Domain Module was added to house the LocationOfInterest model and related use cases.
  • Dependency Refactor: The LoiProperties model was moved to the domain module, reducing dependencies in the app module.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a use case for fetching LoiReport and moves some related models to the domain layer. The changes are well-structured and move towards better separation of concerns. I've identified a few areas for improvement, including a potential data type loss issue during GeoJSON conversion, some naming inconsistencies in the new Dagger module, and an incorrect copyright year in new files which violates the repository's style guide.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.47%. Comparing base (c394f74) to head (222107b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...oundplatform/android/repository/LoiDataProvider.kt 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3605      +/-   ##
============================================
- Coverage     69.50%   69.47%   -0.03%     
  Complexity     1812     1812              
============================================
  Files           346      347       +1     
  Lines          9579     9583       +4     
  Branches       1028     1028              
============================================
  Hits           6658     6658              
- Misses         2291     2296       +5     
+ Partials        630      629       -1     
Files with missing lines Coverage Δ
...data/local/room/entity/LocationOfInterestEntity.kt 100.00% <ø> (ø)
...al/room/entity/LocationOfInterestMutationEntity.kt 94.44% <ø> (ø)
...d/data/remote/firebase/protobuf/ModelToProtoExt.kt 84.84% <ø> (ø)
...oid/model/locationofinterest/LocationOfInterest.kt 96.42% <ø> (+6.42%) ⬆️
...droid/model/mutation/LocationOfInterestMutation.kt 100.00% <ø> (ø)
...android/repository/LocationOfInterestRepository.kt 62.61% <ø> (ø)
...form/android/ui/common/LocationOfInterestHelper.kt 100.00% <ø> (ø)
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 37.40% <ø> (ø)
...oundplatform/android/repository/LoiDataProvider.kt 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andreia-ferreira andreia-ferreira merged commit 4d10715 into master Mar 11, 2026
9 checks passed
@andreia-ferreira andreia-ferreira deleted the andreia/3575/add-usecase branch March 11, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants