Add usecase to get Loi reports#3605
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on adding the functionality to retrieve a Location of Interest (LOI) report, which includes the geoJson representation of the LOI. This report will be used to display the LOI in the UI using a QR code. The changes involve creating a new Domain Module, refactoring dependencies, and implementing the use case to fetch the LOI report. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a use case for fetching LoiReport and moves some related models to the domain layer. The changes are well-structured and move towards better separation of concerns. I've identified a few areas for improvement, including a potential data type loss issue during GeoJSON conversion, some naming inconsistencies in the new Dagger module, and an incorrect copyright year in new files which violates the repository's style guide.
core/domain/src/commonMain/kotlin/org/groundplatform/domain/usecases/GetLoiReportUseCase.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/groundplatform/android/di/DomainModule.kt
Outdated
Show resolved
Hide resolved
core/domain/src/commonMain/kotlin/org/groundplatform/domain/usecases/GetLoiReportUseCase.kt
Show resolved
Hide resolved
core/domain/src/commonMain/kotlin/org/groundplatform/domain/usecases/GetLoiReportUseCase.kt
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3605 +/- ##
============================================
- Coverage 69.50% 69.47% -0.03%
Complexity 1812 1812
============================================
Files 346 347 +1
Lines 9579 9583 +4
Branches 1028 1028
============================================
Hits 6658 6658
- Misses 2291 2296 +5
+ Partials 630 629 -1
🚀 New features to boost your workflow:
|
Towards #3575
This PR adds the use case to fetch a
LoiReport, which will be initially used to hold the geoJson which needs to be displayed later on in the UI by QR code. This doesn't change any functionality, the use case will be implemented in a follow upNote:
LocationOfInterestmodel should be in the domain module. However, it was not moved at this stage since it still has some dependencies that need a significant refactor (eg. usage ofjava.util.Date- a dedicated issue has been created for it, since it affects quite a lot of files #3604 )@shobhitagarwal1612 PTAL?