Skip to content

chore: Use local gcl to create custom gcl if on path - #4600

Merged
gmlewis merged 1 commit into
google:masterfrom
stevehipwell:custom-glc-refactor
Oct 2, 2026
Merged

gmlewis merged 1 commit into
google:masterfrom
stevehipwell:custom-glc-refactor

Conversation

@stevehipwell

Copy link
Copy Markdown
Contributor

This PR updates the setup-custom-gcl.sh script to use the golangci-lint on the path if it's v2. It also updates the golangci-lint config for gofumpt to replace the deprecated settings with the latest pattern.

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@gmlewis gmlewis changed the title chore: use local gcl to create custom gcl if on path chore: Use local gcl to create custom gcl if on path Oct 1, 2026
@gmlewis

gmlewis commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

This PR updates the setup-custom-gcl.sh script to use the golangci-lint on the path if it's v2. It also updates the golangci-lint config for gofumpt to replace the deprecated settings with the latest pattern.

You said what this is doing, but not why we need to use golangci-lint on the path - is this to avoid installing a local copy in bin? And if so, is this to save disk space?

@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.59%. Comparing base (48d0a66) to head (678748f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4600   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files         197      197           
  Lines       18326    18326           
=======================================
  Hits        18068    18068           
  Misses        258      258           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevehipwell

Copy link
Copy Markdown
Contributor Author

@gmlewis I'd rather not run untrusted install scripts directly from the internet, especially when I've already got the binary on my machine. I've been manually working around this for a while now, but I was on the train yesterday on a new machine without a connection and had to mess around to get linting working so decided to fix it.

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Oct 1, 2026

@Not-Dhananjay-Mishra Not-Dhananjay-Mishra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis

gmlewis commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Thank you, @Not-Dhananjay-Mishra!
Merging.

@gmlewis
gmlewis merged commit a3ddb8e into google:master Oct 2, 2026
15 checks passed
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants