Skip to content

chore(deps): Switch from gopkg.in/yaml.v3 to go.yaml.in/yaml/v3 in /tools #3907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 1 commit into from
Jan 30, 2026
+5 −2
Merged

chore(deps): Switch from gopkg.in/yaml.v3 to go.yaml.in/yaml/v3 in /tools #3907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ require (
github.com/getkin/kin-openapi v0.133.0
github.com/google/go-cmp v0.7.0
github.com/google/go-github/v82 v82.0.0
go.yaml.in/yaml/v3 v3.0.4
golang.org/x/sync v0.19.0
gopkg.in/yaml.v3 v3.0.1
)

require (
Expand All @@ -23,6 +23,7 @@ require (
github.com/oasdiff/yaml3 v0.0.0-20250309153720-d2182401db90 // indirect
github.com/perimeterx/marshmallow v1.1.5 // indirect
github.com/woodsbury/decimal128 v1.3.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
Copy link
Collaborator

@gmlewis gmlewis Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some other dependency that is still requiring that this be imported into this project?

Copy link
Contributor

@alexandear alexandear Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can check:

$ go mod why -m gopkg.in/yaml.v3
# gopkg.in/yaml.v3
tools/metadata
github.com/getkin/kin-openapi/openapi3
github.com/go-openapi/jsonpointer
github.com/go-openapi/swag
gopkg.in/yaml.v3

After upgrading the github.com/go-openapi/jsonpointer package, gopkg.in/yaml.v3 will disappear:

go get -u github.com/go-openapi/jsonpointer
go mod tidy

Copy link
Collaborator

@gmlewis gmlewis Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even after running this iteratively, "gopkg.in/yaml.v3" acts like a virus and we can't fully get rid of it yet:

...
$ go get -u github.com/getkin/kin-openapi/openapi3
...
$ go get -u github.com/getkin/kin-openapi/openapi3.text
...
$ go get -u github.com/stretchr/testify/assert
...
$ go get -u github.com/stretchr/testify/assert/yaml
...
$ go mod tidy
$ go mod why -m gopkg.in/yaml.v3
# gopkg.in/yaml.v3
tools/metadata
github.com/getkin/kin-openapi/openapi3
github.com/getkin/kin-openapi/openapi3.test
github.com/stretchr/testify/assert
github.com/stretchr/testify/assert/yaml
gopkg.in/yaml.v3

Copy link

@ccoVeille ccoVeille Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try a go mod replace ?

The lib are pure port of go-yaml/yaml

Copy link

@ccoVeille ccoVeille Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't make sense in a lib like yours, I feel. go mod replace is good for program using your lib.

Testify PR/issue is stale

stretchr/testify#1724

Copy link
Collaborator

@gmlewis gmlewis Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I didn't try that. Do you want to submit a PR, @ccoVeille ?

Copy link

@ccoVeille ccoVeille Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I didn't try that. Do you want to submit a PR, @ccoVeille ?

As I stated here, it won't be useful for you guys

#3907 (comment)

As go-github is a library and not a software

)

// Use version at HEAD, not the latest published.
Expand Down
2 changes: 2 additions & 0 deletions tools/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ github.com/ugorji/go/codec v1.2.7 h1:YPXUKf7fYbp/y8xloBqZOw2qaVggbfwMlI8WM3wZUJ0
github.com/ugorji/go/codec v1.2.7/go.mod h1:WGN1fab3R1fzQlVQTkfxVtIBhWDRqOviHU95kRgeqEY=
github.com/woodsbury/decimal128 v1.3.0 h1:8pffMNWIlC0O5vbyHWFZAt5yWvWcrHA+3ovIIjVWss0=
github.com/woodsbury/decimal128 v1.3.0/go.mod h1:C5UTmyTjW3JftjUFzOVhC20BEQa2a4ZKOB5I6Zjb+ds=
go.yaml.in/yaml/v3 v3.0.4 h1:tfq32ie2Jv2UxXFdLJdh3jXuOzWiL1fo0bu/FbuKpbc=
go.yaml.in/yaml/v3 v3.0.4/go.mod h1:DhzuOOF2ATzADvBadXxruRBLzYTpT36CKvDb3+aBEFg=
golang.org/x/sync v0.19.0 h1:vV+1eWNmZ5geRlYjzm2adRgW2/mcpevXNg50YZtPCE4=
golang.org/x/sync v0.19.0/go.mod h1:9KTHXmSnoGruLpwFjVSX0lNNA75CykiMECbovNTZqGI=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
Expand Down
2 changes: 1 addition & 1 deletion tools/metadata/metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
"sync"

"github.com/google/go-github/v82/github"
"gopkg.in/yaml.v3"
"go.yaml.in/yaml/v3"
)

type operation struct {
Expand Down
Loading