SSLEngine.unwrap precondition tests.#1414
Open
prbprbprb wants to merge 3 commits intogoogle:masterfrom
Open
Conversation
juergw
reviewed
Nov 3, 2025
common/src/test/java/org/conscrypt/javax/net/ssl/SSLEngineTest.java
Outdated
Show resolved
Hide resolved
juergw
reviewed
Nov 3, 2025
prbprbprb
force-pushed
the
unwrap_preconditions
branch
from
f415407 to
c012eab
Compare
Contributor
Author
|
Reworked, apologies for the slow turnaround. |
This is completely analagous to google#1412 but for unwrap(). Does not include failing tests for google#1372.
Mirrors the tests for wrap preconditions in google#1420. Does not contain any tests or fixes for bug google#1372. They will follow in a smaller, focussed PR.
prbprbprb
force-pushed
the
unwrap_preconditions
branch
from
4a681bc to
c47f0f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is completely analagous to #1412 but for unwrap().
Does not include failing tests for #1372.