Skip to content

fix(cli): ignore generated ADK runtime data - #6662

Closed
uuzzrm wants to merge 2 commits into
google:mainfrom
uuzzrm:codex/adk-ignore-runtime-state
Closed

fix(cli): ignore generated ADK runtime data#6662
uuzzrm wants to merge 2 commits into
google:mainfrom
uuzzrm:codex/adk-ignore-runtime-state

Conversation

@uuzzrm

@uuzzrm uuzzrm commented Aug 9, 2026

Copy link
Copy Markdown

Summary - Extend adk create to ignore the generated .adk/ runtime directory. - Preserve existing .gitignore entries and avoid duplicating either generated entry. - Add regression coverage for new, existing, newline-terminated, and partially populated .gitignore files. Fixes #6647. ## Testing - pytest tests/unittests/cli/utils/test_cli_create.py -q (31 passed) - ruff check src/google/adk/cli/cli_create.py tests/unittests/cli/utils/test_cli_create.py - pyink --check src/google/adk/cli/cli_create.py tests/unittests/cli/utils/test_cli_create.py - git diff --check The tests run without network access, model access, or credentials. ## Notes This change was prepared with Codex assistance and reviewed against the repository's contribution guidelines. The implementation is intentionally limited to the CLI scaffold's generated-file ignore list and its unit tests.

AI assistance

AI assistance (Codex) was used for repository research, implementation, and test drafting. The diff and validation results are documented here for maintainer review.

@google-cla

google-cla Bot commented Aug 9, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@adk-bot adk-bot added the tools [Component] This issue is related to tools label Aug 9, 2026
@uuzzrm

uuzzrm commented Aug 9, 2026

Copy link
Copy Markdown
Author

@googlebot check cla

1 similar comment
@uuzzrm

uuzzrm commented Aug 9, 2026

Copy link
Copy Markdown
Author

@googlebot check cla

@uuzzrm

uuzzrm commented Aug 9, 2026

Copy link
Copy Markdown
Author

The Google CLA check is now passing, and all current checks are green. The PR is ready for review. Thanks!

@uuzzrm

uuzzrm commented Aug 10, 2026

Copy link
Copy Markdown
Author

Closing this duplicate PR because #6649 already covers the same fix for #6647. The existing PR is the appropriate place for maintainer review.

@uuzzrm uuzzrm closed this Aug 10, 2026
@uuzzrm uuzzrm reopened this Aug 10, 2026
@uuzzrm

uuzzrm commented Aug 10, 2026

Copy link
Copy Markdown
Author

Closing this duplicate PR; #6649 already covers #6647 and is the appropriate place for maintainer review.

@uuzzrm uuzzrm closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools [Component] This issue is related to tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add .adk/ to the .gitignore generated by adk create

3 participants