fix(cli): ignore generated ADK runtime data - #6662
Closed
uuzzrm wants to merge 2 commits into
Closed
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot check cla |
1 similar comment
Author
|
@googlebot check cla |
Author
|
The Google CLA check is now passing, and all current checks are green. The PR is ready for review. Thanks! |
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary - Extend
adk createto ignore the generated.adk/runtime directory. - Preserve existing.gitignoreentries and avoid duplicating either generated entry. - Add regression coverage for new, existing, newline-terminated, and partially populated.gitignorefiles. Fixes #6647. ## Testing -pytest tests/unittests/cli/utils/test_cli_create.py -q(31 passed) -ruff check src/google/adk/cli/cli_create.py tests/unittests/cli/utils/test_cli_create.py-pyink --check src/google/adk/cli/cli_create.py tests/unittests/cli/utils/test_cli_create.py-git diff --checkThe tests run without network access, model access, or credentials. ## Notes This change was prepared with Codex assistance and reviewed against the repository's contribution guidelines. The implementation is intentionally limited to the CLI scaffold's generated-file ignore list and its unit tests.AI assistance
AI assistance (Codex) was used for repository research, implementation, and test drafting. The diff and validation results are documented here for maintainer review.