test(tools): add unit tests for ToolConfirmation#6208
Open
Koushik-Salammagari wants to merge 2 commits into
Open
test(tools): add unit tests for ToolConfirmation#6208Koushik-Salammagari wants to merge 2 commits into
Koushik-Salammagari wants to merge 2 commits into
Conversation
Adds unit-test coverage for the previously untested ToolConfirmation model: default values, custom values, arbitrary JSON-serializable payloads, extra-field rejection (extra=forbid), and dict round-tripping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Description of the change (no existing issue):
Problem:
The
ToolConfirmationmodel ingoogle.adk.tools.tool_confirmationhad nodedicated unit-test coverage.
Solution:
Add a focused, test-only module. No production code is changed. The model is
gated behind an experimental feature flag (which emits a
UserWarningon use);the tests filter that expected warning.
Coverage added:
hint="",confirmed=False,payload=None).payloadaccepts arbitrary JSON-serializable values (lists, strings).extra="forbid"rejects unknown fields with aValidationError.model_dump/model_validate.Testing Plan
Unit Tests:
Manual End-to-End (E2E) Tests:
Not applicable — this is a test-only change with no runtime/user-facing impact.
Checklist