fix(models): Drop stale thought signatures#6202
Open
its-amann wants to merge 2 commits into
Open
Conversation
Keep only the newest thought_signature in request contents so prior turns do not send signatures the model no longer uses. Fixes google#3693
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Response from ADK Triaging Agent Hello @its-amann, thank you for creating this PR! It looks like your Contributor License Agreement (CLA) check is currently failing. Please sign the Google CLA at https://cla.developers.google.com/ to proceed. Once the CLA is signed, we can move forward with triaging and labeling your PR. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3693
Summary
thought_signaturein outgoing request contents.Testing
uv run --extra dev pyink src\google\adk\models\google_llm.py tests\unittests\models\test_google_llm.pyuv run --extra dev ruff check src\google\adk\models\google_llm.py tests\unittests\models\test_google_llm.pyuv run python -m pytest tests\unittests\models\test_google_llm.py::test_generate_content_async_keeps_only_latest_thought_signatureuv run python -m pytest tests\unittests\models\test_google_llm.py::test_generate_content_async_keeps_only_latest_thought_signature tests\unittests\models\test_google_llm.py::test_generate_content_async tests\unittests\models\test_google_llm.py::test_generate_content_async_stream tests\unittests\models\test_google_llm.py::test_generate_content_async_stream_preserves_thinking_and_text_parts