[bot] Merge master/6d1209d3 into rel/dev - #1804
Merged
Merged
Conversation
…e the client to core/langfuse Trace lookups query GET /api/public/v2/observations and fold the observation rows into one TraceSummary per trace: the root row carries session, metadata and latency, and cost is the sum over the trace's rows. HttpxLangfuseClient lives in core/langfuse/client.py, takes a transport for tests, and writes scores to POST /api/public/scores; core/agentic/_langfuse.py re-exports it and TraceSummary as _TraceObj for external importers. Dataset-run-item writes and the trace-version upsert stay on the legacy endpoints. jira: trivial risk: low
…level tests Adds tests/_fake_langfuse.py, a threading.Thread-hosted http.server that answers the five Langfuse v4 endpoints the package uses plus the three legacy ones, records every request, and is configurable per test (dataset items, missing ids, observation paging/empty-first-call, OTLP status/body, scores 429-once). It doubles as a pytest fixture (fake_langfuse in conftest.py, which points the real Langfuse env vars at it) and as a runnable script that prints and records the wire traffic for manual inspection. tests/test_fake_langfuse.py exercises the fixture itself with a real httpx.Client, no mocks. jira: trivial risk: low
…gative or NaN Retry-After time.sleep rejects a negative or NaN delay, so a skewed or hostile Retry-After header would turn a throttled score write into an exception instead of a retry. Such values now use the default delay; the existing cap still bounds long waits. jira: trivial risk: low
feat(gooddata-eval): read Langfuse traces via v2 observations; move the client to core/langfuse
yenkins-admin
requested review from
hkad98,
lupko and
pcerny
as code owners
September 10, 2026 09:12
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1804 +/- ##
===========================================
+ Coverage 82.01% 82.13% +0.11%
===========================================
Files 280 282 +2
Lines 20208 20286 +78
===========================================
+ Hits 16574 16662 +88
+ Misses 3634 3624 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 6d1209d (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/34459353805).