Skip to content

sdks/ts: add MetadataJSON types to metadata pipeline#2856

Closed
Myestery wants to merge 3 commits intomainfrom
fix/sdks-ts-metadata-types
Closed

sdks/ts: add MetadataJSON types to metadata pipeline#2856
Myestery wants to merge 3 commits intomainfrom
fix/sdks-ts-metadata-types

Conversation

@Myestery
Copy link
Copy Markdown
Contributor

@Myestery Myestery commented Mar 2, 2026

Summary

  • Add MethodMetadataJSON, ClassMetadataJSON, MetadataJSON type definitions to golem-ts-types-core
  • Replace any with MetadataJSON in loadFromJson, removing all as any casts
  • Use ClassMetadataJSON and MethodMetadataJSON in typegen saveAndClearInMemoryMetadata
  • Use MetadataJSON in TypescriptTypeRegistry.register

Context

Split from #2845 — this PR adds proper types to the metadata JSON pipeline only (~40 lines changed across 3 files).

Test plan

  • Existing SDK tests pass
  • Typegen metadata generation produces the same output

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 2, 2026

✅ All contributors have signed the CLA.
Posted by the CLA Assistant Lite bot.

@Myestery Myestery force-pushed the fix/sdks-ts-metadata-types branch from 246608f to ea0c837 Compare March 9, 2026 22:35
@vigoo
Copy link
Copy Markdown
Contributor

vigoo commented Mar 16, 2026

The failing integration tests show that this change breaks the sdk somehow, need to be fixed before merge

@vigoo vigoo closed this Mar 31, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants