Support Commit Amends - #323
Conversation
YeldhamDev
left a comment
There was a problem hiding this comment.
Tested the changes on my end, it works.
|
I'm not sure what the cause of the failed tests is |
|
@sorascode Might be resolved by updating to the latest godot-cpp codebase. Right now, it is https://github.com/godotengine/godot-cpp/blob/54136ee8357c5140a3775c54f08db5f7deda2058/.github/actions/godot-cache/action.yml#L15, but this file doesn't exist on its master anymore The version we have in master right now is referencing a workflow that doesn't exist in godot-cpp anymore. |
|
Ah okay you have already done this change. I think then probably Github CI isn't picking up on the submodule change when checking out the repo? Maybe a separate PR to update godot-cpp, merging it to master, and then rebasing this one on top of master could work? Or the other alternative is to merge this in and make incremental fixes to CI |
This PR adds support for Commit Amends.
This is a draft until the Engine PR is merged and C++ Bindings are updated.
Related Engine PR: godotengine/godot#117968