Skip to content

Support Commit Amends - #323

Open
sorascode wants to merge 2 commits into
godotengine:masterfrom
sorascode:commit-amends
Open

Support Commit Amends#323
sorascode wants to merge 2 commits into
godotengine:masterfrom
sorascode:commit-amends

Conversation

@sorascode

@sorascode sorascode commented Mar 31, 2026

Copy link
Copy Markdown

This PR adds support for Commit Amends.

This is a draft until the Engine PR is merged and C++ Bindings are updated.

Related Engine PR: godotengine/godot#117968

@YeldhamDev YeldhamDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes on my end, it works.

@YeldhamDev
YeldhamDev marked this pull request as ready for review April 2, 2026 00:47
@sorascode

Copy link
Copy Markdown
Author

I'm not sure what the cause of the failed tests is

@twaritwaikar

twaritwaikar commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@sorascode Might be resolved by updating to the latest godot-cpp codebase. Right now, it is https://github.com/godotengine/godot-cpp/blob/54136ee8357c5140a3775c54f08db5f7deda2058/.github/actions/godot-cache/action.yml#L15, but this file doesn't exist on its master anymore

The version we have in master right now is referencing a workflow that doesn't exist in godot-cpp anymore.

@twaritwaikar

twaritwaikar commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Ah okay you have already done this change. I think then probably Github CI isn't picking up on the submodule change when checking out the repo? Maybe a separate PR to update godot-cpp, merging it to master, and then rebasing this one on top of master could work?

Or the other alternative is to merge this in and make incremental fixes to CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants