In tests, remove the word "example" to avoid confusion - #2031
Open
dsnopek wants to merge 1 commit into
Open
Conversation
dsnopek
added
the
enhancement
Ivorforce
approved these changes
Jul 29, 2026
Ivorforce
left a comment
Ivorforce
left a comment
Member
There was a problem hiding this comment.
Really like this idea!
While we're here, perhaps you want to go one step further and add a Readme.md in the test/ folder that links to godot-cpp-template? Not sure if it would be seen by many, but at least we'd have the information in place.
Collaborator
|
Bike-shedding: Why not call it what it is, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project in
test/is not an example, but it still contains the word "example" all over the place, potentially leading to confusion.This PR replaces that with "my_test" or
MyTest. I usually use the prefix "my" for things that are project specific and I never intend to make reusable. I'm open to suggestions on the naming, although, I don't think it matters too much, so long as it can't be confused for an example :-)