Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new objectsigner/auto plugin module that constructs an object Signer based on git signing configuration inputs (gpg.format, user.signingKey), delegating to the existing gpg and ssh signer plugins.
Changes:
- Introduces
FromConfig+ resolution logic for SSH (private key path,key::literal via agent,.pubpath via agent) and OpenPGP (armored keyring file) signing. - Adds extensive tests covering SSH agent/path selection, encrypted/unsupported keys, and
~path expansion behavior. - Adds a standalone Go module (
go.mod/go.sum) for the new plugin, with local replaces to sibling plugins.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| plugin/objectsigner/auto/auto.go | Implements signer selection + key loading for SSH/OpenPGP based on config inputs. |
| plugin/objectsigner/auto/auto_test.go | Adds comprehensive tests for resolution rules and error cases. |
| plugin/objectsigner/auto/go.mod | Declares the new auto plugin module and dependencies (with local replaces). |
| plugin/objectsigner/auto/go.sum | Adds dependency checksums for the new module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pjbgf
force-pushed
the
auto
branch
2 times, most recently
from
e9a8466 to
e91c16f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Introduces an auto-detection signer that inspects git signing configuration (gpg.format and user.signingKey) and delegates to the appropriate GPG or SSH signer. Signed-off-by: Paulo Gomes <paulo@entire.io> Assisted-by: Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Entire-Checkpoint: ae319769e07d
Signed-off-by: Paulo Gomes <paulo@entire.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces an auto-detection signer that inspects git signing configuration (gpg.format and user.signingKey) and delegates to the appropriate GPG or SSH signer.
Fixes #3.