fix(android): portrait falsy report when degrees don't match clauses

[gladiuscode]

This PR fixes #90

Summary by CodeRabbit

• Bug Fixes
  • Improved device orientation detection to more accurately handle edge cases when orientation state is ambiguous, ensuring more reliable and consistent app behavior during screen transitions.

[coderabbitai]

Walkthrough

The PR modifies the default fallback behavior in the convertToDeviceOrientationFrom utility function, changing the return value from Orientation.PORTRAIT to Orientation.UNKNOWN when no specific orientation conditions match during device orientation detection.

Changes

Cohort / File(s)	Summary
Orientation Fallback Behavior android/src/main/java/com/orientationdirector/implementation/Utils.kt	Changed default case in convertToDeviceOrientationFrom to return Orientation.UNKNOWN instead of Orientation.PORTRAIT

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

• [BUG] False alarm of the listener when turning the phone from landscape to faceUp #90: The default return change from PORTRAIT to UNKNOWN directly addresses spurious PORTRAIT readings that can occur during device orientation transitions.

Possibly related PRs

• fix(android): increase tolerance to tilts and improve landscape checks #78: Also modifies convertToDeviceOrientationFrom in Utils.kt with updates to tolerance and landscape orientation checks.
• fix(android): broken interface computation #89: Directly related as it modifies the same convertToDeviceOrientationFrom function's fallback/default orientation logic.

Poem

🐰 When sensors spin without a clear direction,
We hop toward UNKNOWN with fresh reflection,
No false PORTRAIT when paths don't align,
Just honest ambiguity—and that's just fine! 🧭

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix(android): portrait falsy report when degrees don't match clauses' directly addresses the main change: fixing incorrect default behavior where PORTRAIT was returned instead of UNKNOWN when orientation degrees don't match any conditions.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/90-bug-false-alarm-of-the-listener-when-turning-the-phone-from-landscape-to-faceup

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}