Skip to content

fix: resolve react-is version mismatch and .gitattributes syntax error#2650

Merged
setchy merged 1 commit intomainfrom
react-is-override
Mar 2, 2026
Merged

fix: resolve react-is version mismatch and .gitattributes syntax error#2650
setchy merged 1 commit intomainfrom
react-is-override

Conversation

@codebytere
Copy link
Collaborator

@codebytere codebytere commented Mar 2, 2026

Override react-is to v19.2.4 via pnpm overrides to fix CounterLabel crash:

chunk-ZTL4OTR6.js?v=90b5cbd1:3741 Uncaught Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: <CounterLabel />. Did you accidentally export a JSX literal instead of a component?

Check the render method of ForwardRef.
at createFiberFromTypeAndProps (chunk-ZTL4OTR6.js?v=90b5cbd1:3741:30)
at createFiberFromElement (chunk-ZTL4OTR6.js?v=90b5cbd1:3754:16)
at reconcileChildFibersImpl (chunk-ZTL4OTR6.js?v=90b5cbd1:5120:248)
at chunk-ZTL4OTR6.js?v=90b5cbd1:5237:35
at reconcileChildren (chunk-ZTL4OTR6.js?v=90b5cbd1:7182:53)
at beginWork (chunk-ZTL4OTR6.js?v=90b5cbd1:8701:104)
at runWithFiberInDEV (chunk-ZTL4OTR6.js?v=90b5cbd1:997:72)
at performUnitOfWork (chunk-ZTL4OTR6.js?v=90b5cbd1:12561:98)
at workLoopSync (chunk-ZTL4OTR6.js?v=90b5cbd1:12424:43)
at renderRootSync (chunk-ZTL4OTR6.js?v=90b5cbd1:12408:13)

react-is@18.3.1 checks for Symbol(react.element) but React 19 uses Symbol(react.transitional.element), causing isElement() to return false in @primer/react's ButtonBase and blow up at runtime.

Also fix .gitattributes syntax error from stray merge conflict marker:

Screenshot 2026-03-02 at 11 10 57 AM
Before

Screenshot 2026-03-02 at 10 53 58 AM

After

Screenshot 2026-03-02 at 11 05 54 AM

Override react-is to v19.2.4 via pnpm overrides to fix CounterLabel
crash. react-is@18.3.1 checks for Symbol(react.element) but React 19
uses Symbol(react.transitional.element), causing isElement() to return
false in @primer/react's ButtonBase and blow up at runtime.

Also fix .gitattributes syntax error from stray merge conflict marker.
@github-actions github-actions bot added bug Something isn't working dependency Dependency updates labels Mar 2, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2026

@setchy setchy merged commit 817ad09 into main Mar 2, 2026
18 checks passed
@setchy setchy deleted the react-is-override branch March 2, 2026 10:58
@github-actions github-actions bot added this to the Release 7.0.0 milestone Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependency Dependency updates

Development

Successfully merging this pull request may close these issues.

2 participants