Skip to content

fix: strip surrounding quotes from --allow-domains value in agent log firewall parsing #24409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Apr 4, 2026
Merged

fix: strip surrounding quotes from --allow-domains value in agent log firewall parsing #24409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d168ab
Initial plan
Copilot Apr 4, 2026
9e0e331
fix: strip surrounding quotes from --allow-domains in firewall log pa…
Copilot Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/cli/firewall_log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,8 +468,10 @@ func extractFirewallFromAgentLog(logsPath string, verbose bool) *FirewallAnalysi
blockedDomainsSet := make(map[string]bool)
for line := range strings.SplitSeq(string(content), "\n") {
if matches := agentLogAllowDomainsPattern.FindStringSubmatch(line); len(matches) > 1 {
// Strip surrounding double quotes if present (e.g., --allow-domains "dom1,dom2")
allowDomains := strings.Trim(matches[1], "\"")
// Domains can be comma-separated in the suggestion
for domain := range strings.SplitSeq(matches[1], ",") {
for domain := range strings.SplitSeq(allowDomains, ",") {
if d := strings.TrimSpace(domain); d != "" {
blockedDomainsSet[d] = true
}
Expand Down
8 changes: 8 additions & 0 deletions pkg/cli/firewall_log_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,6 +832,14 @@ add --allow-domains anthropic.com to your command`,
wantTotalReqs: 2,
wantBlockedReqs: 2,
},
{
name: "quoted comma-separated domains strips surrounding double quotes",
logContent: `[WARN] To fix domain issues: --allow-domains "*.githubusercontent.com,api.openai.com,chatgpt.com"`,
wantNil: false,
wantBlocked: []string{"*.githubusercontent.com", "api.openai.com", "chatgpt.com"},
wantTotalReqs: 3,
wantBlockedReqs: 3,
},
{
name: "deduplicated repeated warnings for same domain",
logContent: `add --allow-domains chatgpt.com to your command
Expand Down
Loading