Deduplicate main-action Jest harness setup across coverage-gap suites by Copilot · Pull Request #6691 · github/gh-aw-firewall

Copilot · 2026-07-28T16:40:16Z

Both main-action test suites repeated the same fs mock boilerplate and harness-adjacent setup patterns, creating sync risk and unnecessary maintenance churn. This PR consolidates the duplicated fs mock wiring into a shared test utility and updates both suites to consume it.

What changed
- Added src/commands/main-action-fs-mock.test-utils.ts to centralize shared fs mock state and factory logic.
- Replaced inline jest.mock('fs', ...) blocks in:
  - src/commands/main-action.test.ts
  - src/commands/main-action-coverage-gaps.test.ts
- Kept per-suite behavior intact by reusing the same named mock handles (mkdirSync, writeFileSync, chmodSync, openSync, closeSync) via shared exports.
Why this refactor matters
- Removes duplicate mock wiring from both suites.
- Reduces drift risk when mock behavior needs to change.
- Keeps setup intent explicit while moving implementation to one source of truth.

Example

// shared utility
export const mainActionFsMocks = {
  mkdirSync: jest.fn(),
  writeFileSync: jest.fn(),
  chmodSync: jest.fn(),
  openSync: jest.fn().mockReturnValue(42),
  closeSync: jest.fn(),
};

export function mainActionFsMockFactory() {
  const actual = jest.requireActual<typeof import('fs')>('fs');
  return {
    ...actual,
    mkdirSync: (...args: unknown[]) => mainActionFsMocks.mkdirSync(...args),
    writeFileSync: (...args: unknown[]) => mainActionFsMocks.writeFileSync(...args),
    chmodSync: (...args: unknown[]) => mainActionFsMocks.chmodSync(...args),
    openSync: (...args: unknown[]) => mainActionFsMocks.openSync(...args),
    closeSync: (...args: unknown[]) => mainActionFsMocks.closeSync(...args),
  };
}

Fixes [Duplicate Code] Main-action test harness setup is duplicated across coverage-gap suites #6676

Copilot

Pull request overview

Centralizes duplicated filesystem mocks used by the main-action Jest suites.

Changes:

Adds a shared filesystem mock factory and mock handles.
Updates both main-action suites to consume the utility.

Show a summary per file

File	Description
`src/commands/main-action-fs-mock.test-utils.ts`	Defines shared filesystem mocks.
`src/commands/main-action.test.ts`	Uses shared mocks and handles.
`src/commands/main-action-coverage-gaps.test.ts`	Uses the shared mock factory.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 3/3 changed files
Comments generated: 2
Review effort level: Medium

+import { mainActionFsMockFactory, mainActionFsMocks } from './main-action-fs-mock.test-utils';
+
+jest.mock('fs', () => mainActionFsMockFactory());


-    closeSync: (...args: unknown[]) => mockCloseSync(...args),
-  };
-});
+jest.mock('fs', () => mainActionFsMockFactory());


lpcox · 2026-07-28T17:12:51Z

@copilot address review feedback

Copilot · 2026-07-28T17:16:25Z

@copilot address review feedback

Fixed in the latest commit. Both jest.mock('fs', ...) calls now use lazy require inside the factory callback instead of closing over the imported mainActionFsMockFactory binding — matching the pattern used in src/workdir-setup.test.ts:5-12. All 43 tests continue to pass.

github-actions · 2026-07-28T19:00:42Z

✅ Copilot review passed with no inline comments.

@copilot Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

github-actions · 2026-07-28T19:03:18Z

⚠️ Coverage Regression Detected

This PR decreases test coverage. Please add tests to maintain coverage levels.

Overall Coverage

Metric	Base	PR	Delta
Lines	99.17%	99.19%	📈 +0.02%
Statements	99.07%	99.09%	📈 +0.02%
Functions	99.45%	99.35%	📉 -0.10%
Branches	95.75%	95.75%	➡️ +0.00%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/log-directory-setup.ts`	96.2% → 100.0% (+3.78%)	96.3% → 100.0% (+3.71%)

✨ New Files (1 files)

src/commands/main-action-fs-mock.test-utils.ts: 88.9% lines

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-07-28T22:14:32Z

❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed...

github-actions · 2026-07-28T22:14:33Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

github-actions · 2026-07-28T22:14:34Z

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

github-actions · 2026-07-28T22:14:37Z

🔌 Smoke Services — All services reachable! ✅

github-actions · 2026-07-28T22:14:39Z

✅ Smoke Claude passed

github-actions · 2026-07-28T22:14:41Z

✅ Contribution Check completed successfully!

Contribution check complete for PR #6691: no actionable guideline violations found in the provided context.

github-actions · 2026-07-28T22:14:42Z

🚀 Security Guard has started processing this pull request

github-actions · 2026-07-28T22:14:43Z

✅ Build Test Suite completed successfully!

github-actions · 2026-07-28T22:14:48Z

✅ Smoke Gemini completed. All facets verified. 💎

github-actions · 2026-07-28T22:15:03Z

📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-07-28T22:15:08Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-07-28T22:15:27Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-07-28T22:16:26Z

Smoke Test: Claude Engine Validation

Check	Result
API status	✅ PASS
gh check	✅ PASS
File status	✅ PASS

Overall result: PASS

Generated by Smoke Claude for #6691 · haiku45 · 31.4 AIC · ⊞ 3.3K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-07-28T22:16:36Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

github-actions · 2026-07-28T22:16:49Z

🔒 Smoke Test: Copilot Network Isolation

@lpcox

EGRESS_RESULT allow=pass deny=pass

✅ Allowed domain (api.github.com) — HTTP 200
✅ Blocked domain (example.com) — 403 proxy denial

Overall: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

example.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "example.com"

See Network Configuration for more information.

🛡️ Egress verdict from Smoke Copilot Network Isolation
_{Add label ready-for-aw to run again}

github-actions · 2026-07-28T22:16:52Z

🔥 Smoke Test: Copilot BYOK (Direct) — PASS

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy → api.githubcopilot.com

Test	Result
GitHub MCP connectivity	✅
GitHub.com connectivity (HTTP 200)	✅
File write/read	✅
BYOK inference (agent → api-proxy → api.githubcopilot.com)	✅

Overall: PASS — @lpcox

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

github-actions · 2026-07-28T22:17:08Z

Smoke Test: GitHub Actions Services Connectivity

Check	Result
Redis PING	❌ Name resolution failed for `host.docker.internal`
PostgreSQL pg_isready	❌ No response
PostgreSQL SELECT 1	❌ Name resolution failed

Overall: FAIL — host.docker.internal is not resolvable in this environment. The AWF sandbox cannot reach the service containers.

🔌 Service connectivity validated by Smoke Services
_{Add label ready-for-aw to run again}

github-actions · 2026-07-28T22:17:30Z

🔬 Smoke Test Results

Test	Result
GitHub MCP Connectivity	⚠️ Filtered by secrecy policy
GitHub.com HTTP	✅ 200 OK
File Write/Read	⚠️ Pre-step data not expanded

Overall: PARTIAL — core HTTP connectivity passed; pre-computed smoke data unavailable (template variables not expanded at runtime).

@lpcox

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

github-actions · 2026-07-28T22:17:56Z

Gemini Smoke Test Results

GitHub MCP Testing: ❌ (Results filtered by secrecy policy)
GitHub.com Connectivity: ❌ (Network unreachable)
File Writing Testing: ✅
Bash Tool Testing: ✅

Overall Status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini
_{Add label ready-for-aw to run again}

github-actions · 2026-07-28T22:19:01Z

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	`Python 3.12.13`	`Python 3.12.13`	✅ YES
Node.js	`v24.18.0`	`v22.23.1`	❌ NO
Go	`go1.22.12`	`go1.22.12`	✅ YES

Result: FAILED — Node.js version mismatch (host v24.18.0 vs chroot v22.23.1).

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

github-actions · 2026-07-28T22:19:16Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	All passed	✅ PASS
Node.js	execa	✅	All passed	✅ PASS
Node.js	p-limit	✅	All passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Note (Java): The default Maven local repo path /home/runner/.m2/repository was owned by root (no write permission). Resolved by using -Dmaven.repo.local=/tmp/gh-aw/agent/m2-repo as a writable alternative. All Maven downloads, compiles, and tests succeeded.

Generated by Build Test Suite for #6691 · sonnet46 · 46.4 AIC · ⊞ 8.4K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-07-28T22:19:19Z

🔬 Smoke Test: API Proxy OpenTelemetry Tracing

Scenario	Result	Notes
1. Module Loading	✅	`otel.js` loads successfully; exports: `startRequestSpan`, `setTokenAttributes`, `setBudgetAttributes`, `endSpan`, `endSpanError`, `shutdown`, `isEnabled`
2. Test Suite	✅	`otel.test.js` exists with full test coverage using `InMemorySpanExporter`; `otel-fanout.test.js` also present
3. Env Var Forwarding	✅	`src/services/api-proxy-env-config.ts` forwards `GH_AW_OTLP_ENDPOINTS`, `OTEL_EXPORTER_OTLP_ENDPOINT`, `OTEL_EXPORTER_OTLP_HEADERS`, `GITHUB_AW_OTEL_TRACE_ID`, `GITHUB_AW_OTEL_PARENT_SPAN_ID`, `OTEL_SERVICE_NAME`
4. Token Tracker Integration	✅	`onUsage` callback present in `token-tracker-http.js` (line 348/406) as the OTEL hook point
5. OTEL Diagnostics	✅	Module reports `isEnabled: true` (file fallback to `/var/log/api-proxy/otel.jsonl` when no OTLP endpoint configured)

Summary: All 5 scenarios pass. OTEL tracing integration is complete — span creation, token usage attributes (GenAI semantic conventions), parent context propagation, OTLP fan-out export, and graceful degradation via file fallback are all implemented and tested.

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

github-actions · 2026-07-28T22:19:32Z

Reviewed PRs: feat(api-proxy): use runtime model metadata and pricing overlays; chore: upgrade gh-aw extension to v0.83.4 pre-release and recompile workflows
GitHub reads: ✅
Playwright: ✅
File write/read: ✅
Build: ❌ (npm ci hit 403 on yocto-queue)
Overall: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

github-actions · 2026-07-28T22:21:10Z

🧪 Smoke Test: Docker Sbx — PASS

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP	✅ 200
File write/read	✅

Overall: PASS @lpcox

📰 BREAKING: Report filed by Smoke Docker Sbx
_{Add label ready-for-aw to run again}

Initial plan

22ca978

Copilot AI assigned Copilot and lpcox Jul 28, 2026

Copilot started work on behalf of lpcox July 28, 2026 16:42 View session

Copilot AI linked an issue Jul 28, 2026 that may be closed by this pull request

[Duplicate Code] Main-action test harness setup is duplicated across coverage-gap suites #6676

Closed

test: dedupe main-action fs mock setup

5d2bd3f

Copilot AI changed the title ~~[WIP] Fix duplicate code in main-action test setup~~ Deduplicate main-action Jest harness setup across coverage-gap suites Jul 28, 2026

Copilot finished work on behalf of lpcox July 28, 2026 16:45

Copilot AI requested a review from lpcox July 28, 2026 16:45

lpcox marked this pull request as ready for review July 28, 2026 16:48

Copilot AI review requested due to automatic review settings July 28, 2026 16:48

Copilot started reviewing on behalf of lpcox July 28, 2026 16:48 View session

Copilot AI reviewed Jul 28, 2026

View reviewed changes

Copilot started work on behalf of lpcox July 28, 2026 17:13 View session

test: use lazy require in jest.mock factories to avoid hoisting issue

90fcc44

Copilot finished work on behalf of lpcox July 28, 2026 17:16

lpcox added the ready-for-aw label Jul 28, 2026

lpcox had a problem deploying to aoai-model July 28, 2026 22:15 — with GitHub Actions Failure

github-actions Bot added the smoke-claude label Jul 28, 2026

github-actions Bot added the smoke-copilot-network-isolation Copilot network-isolation egress smoke test label Jul 28, 2026

github-actions Bot added the smoke-copilot-byok label Jul 28, 2026

lpcox temporarily deployed to aoai-model July 28, 2026 22:17 — with GitHub Actions Inactive

github-actions Bot mentioned this pull request Jul 28, 2026

[aw] No-Op Runs #6693

Closed

github-actions Bot added the build-test label Jul 28, 2026

github-actions Bot mentioned this pull request Jul 28, 2026

[aw] Smoke Codex is missing required tool #6701

Closed

github-actions Bot added the smoke-docker-sbx label Jul 28, 2026

lpcox merged commit ccee1ee into main Jul 28, 2026
135 of 139 checks passed

lpcox deleted the copilot/fix-duplicate-test-setup branch July 28, 2026 22:42

This was referenced Jul 29, 2026

[aw] No-Op Runs #6709

Open

fix(dns): filter non-portable DNS in network-isolation + Tailscale #6705

Merged

docs: Runner Doctor 2026-07-28 scan — B15/B16 fixed, B13 log-aggregator update, A18 new XDG_CONFIG_HOME mode #6706

Merged

		import { mainActionFsMockFactory, mainActionFsMocks } from './main-action-fs-mock.test-utils';

		jest.mock('fs', () => mainActionFsMockFactory());

Uh oh!

Conversation

Copilot AI commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

lpcox commented Jul 28, 2026

Uh oh!

Copilot AI commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

⚠️ Coverage Regression Detected

Overall Coverage

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026

🔒 Smoke Test: Copilot Network Isolation

Uh oh!

github-actions Bot commented Jul 28, 2026

🔥 Smoke Test: Copilot BYOK (Direct) — PASS

Uh oh!

github-actions Bot commented Jul 28, 2026

Smoke Test: GitHub Actions Services Connectivity

Uh oh!

github-actions Bot commented Jul 28, 2026

🔬 Smoke Test Results

Uh oh!

github-actions Bot commented Jul 28, 2026

Gemini Smoke Test Results

Uh oh!

github-actions Bot commented Jul 28, 2026

Chroot Version Comparison Results

Uh oh!

github-actions Bot commented Jul 28, 2026

Copilot AI commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading