Remove no workflow files prerequisite#43229
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
There was a problem hiding this comment.
Pull request overview
Removes an inaccurate prerequisite from the “Publishing actions in GitHub Marketplace” article, aligning the documentation with actual requirements for publishing actions.
Changes:
- Removed the prerequisite stating that action repositories must not contain workflow files.
|
@tommoor This is definitely something I'll have to confirm. |
|
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment. |
|
I commented in the related issue but I don't know whether those comments are being tracked, so I will repeat here, apologies if it's redundant: I agree this is a confusing requirement. There examples in GitHub's own repos (e.g. https://github.com/actions/setup-node) that appear to contradict it. And even this GitHub docs page (https://docs.github.com/en/actions/how-tos/create-and-publish-actions/release-and-maintain-actions) appears to recommend the use of workflows for maintaining actions. The statement that it is enforced is also plainly false, at least on the natural reading. Thanks. |
|
@tommoor @hesreallyhim I confirmed this list item shouldn't be here. It was probably trying to say something else, but no one thinks it matters enough to track down what it was trying to say, so deleting it is fine. I'll get this approved. |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes: #43228
What's being changed (if available, include any code snippets, screenshots, or gifs):
I removed the incorrect prerequisite
Check off the following: