React to send becoming nonblocking #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveSandersonMS
force-pushed
the
stevesa/send-nonblocking
branch
from
e6ebae2 to
bfbc4bd
Compare
Contributor
Author
|
E2E tests will fail until the CLI is updated to a build that supports this |
There was a problem hiding this comment.
Pull request overview
This PR adds a new sendAndWait() method across all SDK languages (Node.js, Python, Go, .NET) that sends a message and blocks until the agent turn completes. This accompanies a CLI change that makes send() non-blocking. The PR also adds snapshot test infrastructure protection to prevent snapshot corruption on test failures.
Changes:
- Implements
sendAndWait()method in all four SDK languages with consistent behavior (60s default timeout, returns final assistant message) - Updates all E2E tests to use
sendAndWait()instead ofsend()+ helper methods - Adds snapshot corruption protection by skipping snapshot writes when tests fail
Reviewed changes
Copilot reviewed 48 out of 51 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| python/copilot/session.py | Adds send_and_wait() method that waits for session.idle |
| nodejs/src/session.ts | Adds sendAndWait() method with AssistantMessageEvent return type |
| go/session.go | Adds SendAndWait() method with timeout parameter |
| dotnet/src/Session.cs | Adds SendAndWaitAsync() with TimeSpan timeout |
| python/e2e/conftest.py | Adds test failure tracking to avoid corrupting snapshots |
| nodejs/test/e2e/harness/sdkTestContext.ts | Tracks test failures to skip snapshot writes |
| go/e2e/testharness/context.go | Passes test failure status to proxy stop |
| dotnet/test/Harness/E2ETestContext.cs | Uses CI environment variable to skip snapshot writes |
| test/harness/replayingCapiProxy.ts | Supports skipWritingCache query parameter |
| python/e2e/testharness/proxy.py | Adds skip_writing_cache parameter to stop method |
| go/e2e/testharness/proxy.go | Adds StopWithOptions method for conditional snapshot writes |
| dotnet/test/Harness/CapiProxy.cs | Adds skipWritingCache parameter to StopAsync |
| python/e2e/test_session.py | Updates tests to use send_and_wait |
| nodejs/test/e2e/session.test.ts | Updates tests to use sendAndWait, adds new blocking behavior tests |
| go/e2e/session_test.go | Updates tests to use SendAndWait |
| dotnet/test/SessionTests.cs | Updates tests to use SendAndWaitAsync, adds blocking behavior tests |
| nodejs/examples/basic-example.ts | Updates example to use sendAndWait |
| nodejs/README.md | Documents new sendAndWait method |
| test/snapshots/* | Updated snapshots reflecting minor model output variations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
sendAndWait()method to all SDK languages that waits for the agent turn to complete. This accompaniesthe CLI change in https://github.com/github/copilot-agent-runtime/pull/1539 which makes
send()return immediatelyinstead of blocking.
Changes
New API:
sendAndWait()All SDKs now have a method that sends a message and waits for
session.idle:sendAndWait(options, timeout?)Promise<AssistantMessageEvent>SendAndWaitAsync(options, timeout?, ct?)Task<AssistantMessageEvent?>SendAndWait(options, timeout)(*SessionEvent, error)send_and_wait(options, timeout?)SessionEventAll implementations:
assistant.messageevent received beforesession.idlesession.errorevents by throwing/returning an errorSnapshot Test Infrastructure
Added protection against snapshot corruption on test failures.
Updated E2E Tests
All e2e tests updated to use
sendAndWait()instead ofsend()+getFinalAssistantMessage().Backward Compatibility
send()still works, just returns faster)Related