C++: Simplify cpp/sql-injection barrier
#21209
Merged
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQL sanitizers will not likely also be sources, so using `isBarrierIn` here does not make a lot of sense. I ran with and without this change on MRVA and got identical results.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the SQL injection detection query by consolidating barrier predicates. The change removes the isBarrierIn predicate and merges its logic into the isBarrier predicate, based on the reasoning that SQL sanitizer inputs are unlikely to be data flow sources.
Changes:
- Merged
isBarrierInbarrier logic intoisBarrierpredicate in the SQL injection taint tracking configuration - Changed the disjunction syntax from separate predicate to using
oroperator
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
DCA looks clean. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL sanitizers will not likely also be sources, so using
isBarrierInhere does not make a lot of sense.I ran with and without this change on MRVA and got identical results.