C++: Add isLiveAtEndOfBlock predicate to Ssa::Definition
#21202
Merged
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion' predicate. Instead, cache it and call it like we are supposed to.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the isLiveAtEndOfBlock predicate to C++'s Ssa::Definition class to align with other languages' SSA implementations. It also includes a drive-by fix to improve caching consistency by wrapping uncertainWriteDefinitionInput in a cached predicate.
Changes:
- Added
isLiveAtEndOfBlockpredicate to expose SSA definition liveness information at basic block boundaries - Added cached wrappers for
uncertainWriteDefinitionInputandssaDefReachesEndOfBlockpredicates for improved performance - Updated internal usage to leverage the new cached predicate
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
DCA was uneventful. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other languages have this predicate exposed on their version of
Ssa::Definitionso we might as well do so as well.This predicate was necessary in a recent Microsoft query we were writing.
I also did a drive-by fix in 60ee92d. I'll run DCA to make sure I didn't mess up any caching.