Rust: Remove restriction that blanket(-like) impls must have a constraint #21168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/type-inference-remove-blanket-constraint-restriction
branch
3 times, most recently
from
1c63fab to
4bae300
Compare
hvitved
force-pushed
the
rust/type-inference-remove-blanket-constraint-restriction
branch
from
4bae300 to
c0f1462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, blanket implementations without constraints, such as
impl<T> From<T> for T, were ignored, because they would give rise to too many calls with multiple call targets.This PR changes that, and avoids multiple targets by only allowing blanket targets when no compatible non-blanket targets exist (we already had this check in place for method calls).