ref(seer): remove SeerViewerContext from task and consumer paths - #121029
Draft
sehr-m wants to merge 1 commit into
Draft
ref(seer): remove SeerViewerContext from task and consumer paths#121029sehr-m wants to merge 1 commit into
sehr-m wants to merge 1 commit into
Conversation
Remove SeerViewerContext from tasks dispatched by endpoints/webhooks (ViewerContextHook already propagates VC) and from consumer paths (feedback ingest already sets viewer_context_scope, others rely on the chokepoint observation to flag missing VC). Task/consumer paths that already had viewer_context_scope keep it. Cron-dispatched tasks are left for a future PR.
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #121021. Removes
SeerViewerContextfrom task and consumer call sites:ViewerContextHookalready propagates VC from the dispatcher. The explicitSeerViewerContextwas redundant.feedback/usecases/ingest/create_feedback.pyalready hadviewer_context_scope— just removed the redundantSeerViewerContextalongside it. Other consumer paths (event_manager,grouping/ingest/seer) removedSeerViewerContextand rely on the chokepointviewer_context.missingwarning to flag the gap.SeerViewerContext— endpoint callers have VC via middleware, consumer-dispatched task callers will be covered by addingviewer_context_scopein the task body (future work for tasks likegenerate_summary_and_run_automation).What's left (future PR)
statistical_detectors,context_engine_index,explorer_index,service_map_utils) still useSeerViewerContextviewer_context_scopeat task entry points for tasks dispatched from consumer pipelineTest plan
🤖 Generated with Claude Code