Skip to content

chore(ACI): Remove workflow-engine-ui flag from some more places - #121003

Merged
ceorourke merged 1 commit into
masterfrom
ceorourke/remove-workflow-engine-ui-misc
Aug 3, 2026
Merged

chore(ACI): Remove workflow-engine-ui flag from some more places#121003
ceorourke merged 1 commit into
masterfrom
ceorourke/remove-workflow-engine-ui-misc

Conversation

@ceorourke

@ceorourke ceorourke commented Jul 31, 2026

Copy link
Copy Markdown
Member

Remove the ACI UI flag from the command palette, detector sidebar, and metric detector limit.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 31, 2026
@ceorourke
ceorourke marked this pull request as ready for review August 3, 2026 16:59
@ceorourke
ceorourke requested review from a team as code owners August 3, 2026 16:59
@ceorourke
ceorourke removed request for a team August 3, 2026 16:59
cursor[bot]
cursor Bot reviewed Aug 3, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 017425a. Configure here.

Comment thread static/app/components/commandPalette/ui/commandPaletteGlobalActions.tsx Outdated
Comment thread static/app/views/issueDetails/sidebar/detectorSection.tsx

const hasWorkflowEngineUi = organization.features.includes('workflow-engine-ui');
const shouldUseMetricRuleLink = detectorType === 'metric_alert' && !hasWorkflowEngineUi;

@cursor cursor Bot Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metric detector link still gated

Medium Severity

MetricAlertSection was the fallback when metric issues exist but workflow-engine-ui is off, linking to legacy metric alert details. Removing it always uses the monitors path from detectorPath, and monitor pages still redirect home without the flag, so those users lose a working detector CTA.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 017425a. Configure here.

cvxluo
cvxluo approved these changes Aug 3, 2026
View reviewed changes

@cvxluo cvxluo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bot comment seems right but otherwise lgtm

@ceorourke
ceorourke force-pushed the ceorourke/remove-workflow-engine-ui-misc branch from 017425a to ff5a356 Compare August 3, 2026 19:39
@sentry

sentry Bot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
sentry-frontend
sentry-frontend		 0 0 0 0 451 0 ✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

sentry[bot]
sentry Bot reviewed Aug 3, 2026
View reviewed changes
Comment thread static/app/components/commandPalette/ui/commandPaletteGlobalActions.tsx Outdated
@ceorourke
ceorourke force-pushed the ceorourke/remove-workflow-engine-ui-misc branch from ff5a356 to dcb9e99 Compare August 3, 2026 19:50
@ceorourke ceorourke mentioned this pull request Aug 3, 2026
Merged
@ceorourke
ceorourke merged commit 5b88de0 into master Aug 3, 2026
71 checks passed
@ceorourke
ceorourke deleted the ceorourke/remove-workflow-engine-ui-misc branch August 3, 2026 20:24
ceorourke added a commit that referenced this pull request Aug 4, 2026
@ceorourke
chore(ACI): Remove workflow-engine-ui flag from even more places (#12…
9f8eca2 
…1088)

Follow up to #121003 to continue
removing more workflow engine UI code from navigation and the command
palette.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentry sentry[bot] sentry[bot] left review comments
@cursor cursor[bot] cursor[bot] left review comments
@cvxluo cvxluo cvxluo approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ceorourke @cvxluo