feat(ourlogs): sync hover state between pinned and tbody log rows#117034
Merged
Conversation
A pinned log appears both in the pinned section and in the tbody. Hovering either instance now highlights both, so it's clear they're the same row. This was removed from the initial pinning implementation because the hover state lived on the pinning context, forcing every row to re-render on each hover. Now that pinning is prop-drilled, the table owns a single hovered-row id and passes each row a derived boolean, so memo keeps all but the two twin rows from re-rendering. Refs LOGS-841 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
JoshuaKGoldberg
changed the title
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 8bc1747. Configure here.
adrianviquez
reviewed
Jun 9, 2026
adrianviquez
approved these changes
Jun 9, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pinned log shows up twice: once in the pinned section at the top of the table and again in the tbody. Hovering either instance now highlights both so it's clear they're the same row.
Screen.Recording.2026-06-05.at.6.03.38.PM.mov
Closes LOGS-841