ref: delete unused options#116409
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
joshuarli
force-pushed
the
delete-unused-options
branch
from
37ac00c to
b9c25db
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
markstory
approved these changes
May 28, 2026
Member
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
Looks good to me. There are a few clanker comments that are worth addressing for extra polish.
wedamija
approved these changes
May 28, 2026
Member
wedamija
left a comment
wedamija
left a comment
There was a problem hiding this comment.
Pretty scary, but I guess we'll see errors pop up in canary if any of these are mistaken
shashjar
approved these changes
May 28, 2026
Member
shashjar
left a comment
shashjar
left a comment
There was a problem hiding this comment.
very nice, spring cleaning 🎉
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 602e39d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this removes 93 unused options identified via tracking read options via logging in #115610 (which this PR also reverts as I'm done collecting data) cross referenced with static analysis in getsentry/sentry-options#123
the details are in getsentry/sentry-options#123 -
scripts/migration/safe.txtis essentially the set intersection of statically unreferenced options and unseen/unread options over 120 hours of GCP production logs.the unseen list was determined by subtracting options.seen unique events from all known options (options.all()) and I observed no newly seen options beyond the ~100 hour mark (
scripts/migration/collect-seen-options-out.txt).getsentry options that were unused are removed here too: https://github.com/getsentry/getsentry/pull/20449