feat(grouping): Add replacement callback option to parameterizer#111352
Draft
lobsterkatie wants to merge 8 commits intokmclb-more-parameterizer-refactorsfrom
Draft
feat(grouping): Add replacement callback option to parameterizer#111352lobsterkatie wants to merge 8 commits intokmclb-more-parameterizer-refactorsfrom
lobsterkatie wants to merge 8 commits intokmclb-more-parameterizer-refactorsfrom
Conversation
25abad3 to
9bd39e2
Compare
c851f10 to
c4ee25e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to specify a replacement callback when defining a regex for the parameterizer. For example, a regex can now be defined like this:
When the parameterizer finds a matching value, instead of just reflexively replacing it with the regex's name, it'll pass the original value to the callback, and let it decide what the replacement value will be. (This is going to be necessary for us to fix our IPv6 parameterization.)