feat(performance): Add search support to EAP txn summary sample events#111349
feat(performance): Add search support to EAP txn summary sample events#111349
Conversation
…vents for EAP Extract EAPSpansQueryBuilder into a shared component and wire up search/filtering in the Sample Events tab when using EAP mode. The spans table now respects the search query from URL params, and non-applicable controls (percentile filter, Open in Discover) are hidden in EAP mode. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
@mjq Would it be possible to avoid creating another abstraction on the trace item search query builder, or just create it locally where it's needed?
I cleaned up a couple of these abstractions a little while back because they weren't doing anything really unique for their use case, and they were popping up when you would try to implement a query builder and might cause some confusion on which query builder you should use.
There was a problem hiding this comment.
@nsdeschenes Okay cool, makes sense. I inlined the two uses and removed the component. 👍
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| > | ||
| {t('Open in Discover')} | ||
| </LinkButton> | ||
| )} |
There was a problem hiding this comment.
Grid template not adjusted for fewer EAP children
Low Severity
The FilterActions grid template defines 5 columns on xl screens (auto auto 1fr auto auto) and 4 on sm (repeat(4, min-content)), designed for the non-EAP case with 5 children. In EAP mode, only 3 children are rendered (the Percentile select and Open in Discover button are hidden). The empty auto columns still produce gap space (space.xl = 16px each), making the search bar ~32px narrower than intended. The analogous EAP layout in transactionOverview/content.tsx correctly uses a 3-column grid (auto auto 1fr).
2 participants
Extract
EAPSpansQueryBuilderinto a shared component and wire up search/filtering in the Sample Events tab when using EAP mode. The spans table now respects the search query from URL params, and non-applicable controls (percentile filter, Open in Discover) are hidden in EAP mode.Fixes BROWSE-463.