Skip to content

fix(ios): Remove manual geo handling, use sentry-cocoa native support#6289

Open
antonis wants to merge 5 commits into
mainfrom
antonis/remove-manual-geo-handling
Open

fix(ios): Remove manual geo handling, use sentry-cocoa native support#6289
antonis wants to merge 5 commits into
mainfrom
antonis/remove-manual-geo-handling

Conversation

@antonis

@antonis antonis commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Remove manual SentryGeo handling from RNSentry.mm now that sentry-cocoa 9.17.0+ natively supports geo deserialization in SentryUser.initWithDictionary: (via getsentry/sentry-cocoa#8026).

💡 Motivation and Context

Closes #6266

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes - Verified with the existing tests
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@antonis @claude
fix(ios): Remove manual geo handling now that sentry-cocoa supports i…
bd874d6 
…t natively

Closes #6266

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Jun 15, 2026
@github-actions

github-actions Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

  • fix(ios): Remove manual geo handling, use sentry-cocoa native support by antonis in #6289
  • chore: Bump sample and perf test apps to React Native 0.86.0 by antonis in #6287
  • fix(deps): bump form-data from 4.0.5 to 4.0.6 by antonis in #6297
  • fix(ci): Handle @sentry-internal/* package renames in JS updater by antonis in #6295
  • Record network request/response bodies in Session Replay by alwx in #6288
  • chore(deps): bump tar from 7.5.11 to 7.5.16 by dependabot in #6293
  • fix(ci): Update renamed @sentry-internal/* packages in JS updater script by antonis in #6294
  • chore(deps): bump launch-editor from 2.11.1 to 2.14.1 by dependabot in #6291
  • chore(deps-dev): bump @babel/core from 7.26.7 to 7.29.6 by dependabot in #6292
  • fix(deps): Resolve shell-quote to >=1.8.4 (Dependabot RNSentryModule.captureEvent is ignoring environment #547) by antonis in #6286
  • fix(ci): Support version catalog in android SDK version check by antonis in #6280
  • test(e2e): Bump E2E tests to React Native 0.86.0 by antonis in #6268
  • feat(android): Add nativeStackAndroid support to NativeLinkedErrors by lucas-zimerman in #6278
  • chore(deps): bump ruby/setup-ruby from 1.310.0 to 1.313.0 by dependabot in #6282
  • chore(deps): update Maestro to v2.6.1 by github-actions in #6277
  • chore(deps): bump gradle/actions from 6.1.0 to 6.2.0 by dependabot in #6284
  • chore(deps): bump getsentry/craft from 2.26.8 to 2.26.10 by dependabot in #6283
  • chore(deps): bump getsentry/craft/.github/workflows/changelog-preview.yml from 2.26.8 to 2.26.10 by dependabot in #6281
  • chore(deps): update Sentry Android Gradle Plugin to v6.11.0 by github-actions in #6275
  • chore(deps): update Android SDK to v8.43.2 by github-actions in #6273
  • chore(deps): bump joi from 17.13.3 to 17.13.4 by dependabot in #6279
  • chore(deps): update Cocoa SDK to v9.17.1 by github-actions in #6272
  • docs(replay): clarify fast renderer option docs by leohara in #6276
  • feat(core): Warn when multiple versions of Sentry JS SDK are detected by antonis in #6269

🤖 This preview updates automatically when you update the PR.

@sentry

sentry Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
Sentry RN io.sentry.reactnative.sample 8.14.0 (91) Release

⚙️ sentry-react-native Build Distribution Settings

antonis and others added 2 commits June 15, 2026 13:01
@antonis @claude
chore: Revert unneeded project.pbxproj changes from pod update
3c5d1fe 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 3839.24 ms 1212.22 ms -2627.01 ms
Size 5.15 MiB 6.70 MiB 1.54 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
71abba0+dirty 3821.93 ms 1202.81 ms -2619.12 ms
7d8c8bd+dirty 3837.24 ms 1215.51 ms -2621.73 ms
3b6e9f9+dirty 3851.90 ms 1233.33 ms -2618.57 ms
c823bb5+dirty 3843.44 ms 1225.70 ms -2617.74 ms
44c8b3f+dirty 3823.85 ms 1207.66 ms -2616.19 ms
41d6254+dirty 3845.71 ms 1224.51 ms -2621.20 ms
0d9949d+dirty 1211.38 ms 1219.67 ms 8.29 ms
a0d8cf8+dirty 3842.33 ms 1212.40 ms -2629.93 ms
5c1e987+dirty 1204.30 ms 1222.15 ms 17.85 ms
b0d3373+dirty 3831.75 ms 1227.29 ms -2604.46 ms

App size

Revision Plain With Sentry Diff
71abba0+dirty 5.15 MiB 6.67 MiB 1.52 MiB
7d8c8bd+dirty 5.15 MiB 6.68 MiB 1.53 MiB
3b6e9f9+dirty 5.15 MiB 6.68 MiB 1.53 MiB
c823bb5+dirty 5.15 MiB 6.69 MiB 1.53 MiB
44c8b3f+dirty 5.15 MiB 6.66 MiB 1.51 MiB
41d6254+dirty 5.15 MiB 6.70 MiB 1.54 MiB
0d9949d+dirty 3.38 MiB 4.76 MiB 1.38 MiB
a0d8cf8+dirty 5.15 MiB 6.67 MiB 1.51 MiB
5c1e987+dirty 3.38 MiB 4.73 MiB 1.35 MiB
b0d3373+dirty 5.15 MiB 6.68 MiB 1.53 MiB

Previous results on branch: antonis/remove-manual-geo-handling

Startup times

Revision Plain With Sentry Diff
d4fd7ed+dirty 3853.40 ms 1230.61 ms -2622.79 ms

App size

Revision Plain With Sentry Diff
d4fd7ed+dirty 5.15 MiB 6.70 MiB 1.54 MiB

@github-actions

github-actions Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 3821.53 ms 1206.15 ms -2615.38 ms
Size 5.15 MiB 6.70 MiB 1.54 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
71abba0+dirty 3852.70 ms 1224.53 ms -2628.16 ms
7d8c8bd+dirty 3847.98 ms 1230.77 ms -2617.21 ms
3b6e9f9+dirty 3822.77 ms 1208.00 ms -2614.77 ms
c823bb5+dirty 3845.16 ms 1210.33 ms -2634.83 ms
44c8b3f+dirty 3849.24 ms 1209.94 ms -2639.31 ms
41d6254+dirty 3849.78 ms 1233.91 ms -2615.86 ms
0d9949d+dirty 1203.94 ms 1202.27 ms -1.67 ms
a0d8cf8+dirty 3826.15 ms 1213.12 ms -2613.03 ms
5c1e987+dirty 1208.43 ms 1220.72 ms 12.29 ms
b0d3373+dirty 3842.49 ms 1218.49 ms -2624.00 ms

App size

Revision Plain With Sentry Diff
71abba0+dirty 5.15 MiB 6.67 MiB 1.52 MiB
7d8c8bd+dirty 5.15 MiB 6.68 MiB 1.53 MiB
3b6e9f9+dirty 5.15 MiB 6.68 MiB 1.53 MiB
c823bb5+dirty 5.15 MiB 6.69 MiB 1.53 MiB
44c8b3f+dirty 5.15 MiB 6.66 MiB 1.51 MiB
41d6254+dirty 5.15 MiB 6.70 MiB 1.54 MiB
0d9949d+dirty 3.38 MiB 4.76 MiB 1.38 MiB
a0d8cf8+dirty 5.15 MiB 6.67 MiB 1.51 MiB
5c1e987+dirty 3.38 MiB 4.73 MiB 1.35 MiB
b0d3373+dirty 5.15 MiB 6.68 MiB 1.53 MiB

Previous results on branch: antonis/remove-manual-geo-handling

Startup times

Revision Plain With Sentry Diff
d4fd7ed+dirty 3846.87 ms 1226.91 ms -2619.95 ms

App size

Revision Plain With Sentry Diff
d4fd7ed+dirty 5.15 MiB 6.70 MiB 1.54 MiB

@antonis @claude
fix(ios): Update testUserWithInvalidGeo for initWithDictionary behavior
be1e855 
initWithDictionary: puts unrecognized non-dict "geo" values into the
unknown dict, causing isEqualToUser: to fail. Assert individual
properties instead.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@antonis antonis marked this pull request as ready for review June 15, 2026 12:14
@antonis antonis removed the ready-to-merge Triggers the full CI test suite label Jun 16, 2026
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor
Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against be1e855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alwx alwx Awaiting requested review from alwx alwx is a code owner

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove manual geo handling in iOS after sentry-cocoa adds geo support in initWithDictionary:

1 participant

@antonis