feat(ci): Warn instead of fail when values are orphaned#136
Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
joshuarli
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current workflow for the new sentry-options when deleting an option involves:
.get())sentry-options-automator(values.yaml)This is a 3 step process that requires 3 separate PRs and is annoying for product engineers. By going back to how the old system works, this becomes:
sentry-options-automatorThis brings it down to 1 PR, much easier to digest.
We don't lose much safety because the only thing we were guarding against were stale values in the automator repo. We already have workaround for this today and see no problems, so I see no reason why we need to build extra guardrails.
stuff changed