Skip to content

WIP: feat(native): Add Android support#1725

Open
jpnurmi wants to merge 9 commits into
masterfrom
jpnurmi/feat/native-android
Open

WIP: feat(native): Add Android support#1725
jpnurmi wants to merge 9 commits into
masterfrom
jpnurmi/feat/native-android

Conversation

@jpnurmi
Copy link
Copy Markdown
Collaborator

@jpnurmi jpnurmi commented May 15, 2026

  • Support the native crash daemon on Android by using a file-backed shared mapping and passing its fd through daemon startup.
  • Fix Android-specific link issues and include libunwindstack headers for the daemon target.
  • Add Android integration test for the native backend that verifies minidump creation on an emulator.

Support the native crash daemon on Android by using a file-backed shared
mapping and passing its fd through daemon startup. Avoid Android-only link
issues and include libunwindstack headers for the daemon target.

Add Android integration coverage for the native backend that verifies
minidump creation on an emulator.

Co-Authored-By: OpenAI Codex <noreply@openai.com>
Comment thread src/backends/native/sentry_crash_ipc.c Outdated
jpnurmi and others added 2 commits May 15, 2026 14:26
Assign inherited notification fds only after daemon shared memory mapping and
validation succeed so failed Android daemon initialization does not retain them.

Co-Authored-By: OpenAI Codex <noreply@openai.com>
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 92d076e. Configure here.

Comment thread src/backends/native/sentry_crash_ipc.c Outdated
jpnurmi and others added 3 commits May 15, 2026 14:36
app_pid and app_tid are used to reconstruct the Android crash IPC shared memory
path, so do not mark them as unused.

Co-Authored-By: OpenAI Codex <noreply@openai.com>
Comment thread src/backends/native/sentry_crash_ipc.c
jpnurmi and others added 3 commits May 15, 2026 15:58
Use the configured database path for Android crash IPC shared memory files
instead of falling back to shell temp locations.

Co-Authored-By: OpenAI Codex <noreply@openai.com>
Treat an empty ANDROID_API value the same as an unset one so importing test
conditions does not fail before collection.

Co-Authored-By: OpenAI Codex <noreply@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant