feat: Implement the GPU Info gathering within the Native SDK#1336
feat: Implement the GPU Info gathering within the Native SDK#1336
Conversation
|
bruno-garcia
left a comment
bruno-garcia
left a comment
There was a problem hiding this comment.
Just skimmed things but seems great so far!
mujacica
force-pushed
the
native-gpu-info
branch
from
883b465 to
d743b13
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mujacica
force-pushed
the
native-gpu-info
branch
from
960eb4f to
0c22332
Compare
|
@sentry review |
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
supervacuus
left a comment
supervacuus
left a comment
There was a problem hiding this comment.
Somehow my review message got lost... this looks great. Only minor topics that can be "fixed" or clarified.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mujacica
force-pushed
the
native-gpu-info
branch
from
f7eef2b to
06e0f7c
Compare
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
- Use RTLD_NOW instead of RTLD_LAZY for immediate symbol validation - Add dlerror() logging on Unix when Vulkan library fails to load - Add macOS fallback when MoltenVK portability extensions unavailable - Guard against UINT64_MAX overflow when summing GPU memory heaps - Handle string allocation failures in create_gpu_info_from_device - Log when a GPU device is skipped during enumeration - Increase context_key buffer from 16 to 32 bytes - Add ARM (0x13B5) and Samsung (0x144D) vendor IDs - Improve thread safety documentation with specific lock references - Document Vulkan API version requirement and driver version encoding - Disable SENTRY_WITH_GPU_INFO by default (enable with -DSENTRY_WITH_GPU_INFO=ON) - Update CHANGELOG and README to reflect opt-in behavior Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mujacica
force-pushed
the
native-gpu-info
branch
from
06e0f7c to
3e996d9
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Accept VK_INCOMPLETE from vkEnumeratePhysicalDevices as valid (buffer contains data for written entries; also works around Windows loader bugs) - Use a separate context_index counter for GPU context keys so they are contiguous (gpu, gpu2, gpu3) even when some devices fail info creation - Fix clang-format style issues Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Use unload_vulkan_library() instead of manual cleanup to ensure all pfn_* statics are reset to NULL when some Vulkan functions fail to load. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
The previous commit called unload_vulkan_library() before its definition, causing an implicit declaration error on CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 participants
Uh oh!
There was an error while loading. Please reload this page.