ref(server-utils)!: Replace deprecated net.* span attributes on db and messaging spans - #23422
Open
msonnb wants to merge 1 commit into
Open
ref(server-utils)!: Replace deprecated net.* span attributes on db and messaging spans#23422msonnb wants to merge 1 commit into
net.* span attributes on db and messaging spans#23422msonnb wants to merge 1 commit into
Conversation
…and messaging spans Part of the v11 migration away from attributes `@sentry/conventions` marks deprecated, and a direct follow-on to the `db.*` migration (#23408), which touched the same integrations. `net.peer.name` -> `server.address` and `net.peer.port` -> `server.port` on database and messaging client spans, plus `net.transport` -> `network.transport` in Knex. This covers Postgres, MySQL, MySQL2, Knex, MongoDB, Mongoose, Redis, ioredis, Tedious and AMQP. On these spans the socket peer is the server being called, so `server.*` is the right target for the peer attributes. That is not true of HTTP server spans, where the peer is the client — those are migrated separately. AMQP already emitted `server.address`/`server.port` alongside the deprecated pair, so there the deprecated attributes are simply dropped. `redis-cache.ts` still reads `net.peer.name`/`net.peer.port` as a fallback: it also sees spans from a user's own OpenTelemetry instrumentation, which still emits the old conventions. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 8107e2e. Configure here.
Contributor
size-limit report 📦
|
msonnb
marked this pull request as ready for review
August 13, 2026 16:34
msonnb
requested review from
isaacs,
logaretm and
mydea
and removed request for
a team
August 13, 2026 16:34
logaretm
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
net.peer.name->server.addressnet.peer.port->server.portnet.transport->network.transportAMQP already emitted
server.address/server.portalongside the deprecated pair, so there the deprecated attributes are simply dropped.redis-cache.tsstill readsnet.peer.name/net.peer.portas a fallback: it also sees spans from a user's own OpenTelemetry instrumentation, which still emits the old conventions.part of #18895