fix(wasm): Register modules loaded via non-streaming WebAssembly APIs - #23403
Draft
andreiborza wants to merge 2 commits into
Draft
fix(wasm): Register modules loaded via non-streaming WebAssembly APIs#23403andreiborza wants to merge 2 commits into
andreiborza wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 94646d2. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Register WASM modules that are loaded via
WebAssembly.instantiate(buffer),WebAssembly.compile, andnew WebAssembly.Module()so their frames get symbolicated. Modules are registered under the engine's synthetic script name (wasm://wasm/<hash>), computed from the wire bytes; Firefox frames match through a single-module fallback because its names are call-site-derived. Also forwards the compile-options argument in the streaming wrappers and patches frames of all chained exception values.Why
Non-streaming loads (Emscripten fallback and dynamic linking, Godot Web) produced events without
debug_meta, so uploaded symbols were never applied.Fixes #19564