fix(core): Serialize streamed span status message to sentry.status.message attribute#21811
Open
Lms24 wants to merge 5 commits into
Open
fix(core): Serialize streamed span status message to sentry.status.message attribute#21811Lms24 wants to merge 5 commits into
sentry.status.message attribute#21811Lms24 wants to merge 5 commits into
Conversation
Lms24
changed the title
sentry.status.message attributesentry.status.message attribute
Lms24
force-pushed
the
lms/fix-core-streaming-span-status-message
branch
from
fbab8c3 to
c18bd3e
Compare
Contributor
size-limit report 📦
|
Lms24
changed the title
sentry.status.message attributesentry.status.message attribute
Lms24
requested review from
JPeer264,
andreiborza,
logaretm,
mydea and
s1gr1d
and removed request for
a team,
JPeer264 and
andreiborza
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 33fa6af. Configure here.
Lms24
force-pushed
the
lms/fix-core-streaming-span-status-message
branch
from
33fa6af to
360ab29
Compare
JPeer264
approved these changes
Jun 29, 2026
logaretm
approved these changes
Jun 29, 2026
logaretm
reviewed
Jun 29, 2026
| * message as an attribute instead of dropping it. This mirrors the attribute | ||
| * Sentry's OTLP ingestion uses for the same purpose. | ||
| */ | ||
| export const SEMANTIC_ATTRIBUTE_SENTRY_STATUS_MESSAGE = 'sentry.status.message'; |
Member
There was a problem hiding this comment.
q: I know core doesn't have @sentry/conventions dependency yet, but just for the future we should probably import them from there.
Member
Author
There was a problem hiding this comment.
yup, we need to add conventions to core.
logaretm
added a commit
that referenced
this pull request
Jun 29, 2026
Lms24
force-pushed
the
lms/fix-core-streaming-span-status-message
branch
from
360ab29 to
118c27d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a semi-deliberate oversight (lol) from my end that caused span status messages to be discarded when creating a
StreamedSpanJSONfrom aSpaninstance. The deliberate part was to get rid of complicated statuses overall. The oversight was that there's a good use case to augment anerrorstatus span with a message: We sometimes want to record that an operation tracked by a span errored but explicitly not capture an error for it (since users likely try/catch said operation). Classic example isConnection Refusedfor databases.closes #21800