feat(server-utils): Expose channel-based, streamlined fastifyIntegration#21706
Merged
Conversation
mydea
changed the title
fastifyIntegration
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
mydea
force-pushed
the
ref/streamline-fastify-otel-vendored
branch
from
faecc64 to
7edd803
Compare
mydea
requested review from
JPeer264 and
andreiborza
and removed request for
a team
Member
Author
|
@isaacs we can likely also use this as-is in deno and bun (IMHO we can do that in a follow up) |
Contributor
|
👋 @JPeer264, @andreiborza — Please review this PR when you get a chance! |
mydea
force-pushed
the
ref/streamline-fastify-otel-vendored
branch
from
7edd803 to
64f53cd
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 64f53cd. Configure here.
andreiborza
approved these changes
Jun 29, 2026
mydea
force-pushed
the
ref/streamline-fastify-otel-vendored
branch
from
64f53cd to
fbe0085
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Member
Author
|
Failing test depends on #21845 |
JPeer264
approved these changes
Jun 29, 2026
mydea
force-pushed
the
ref/streamline-fastify-otel-vendored
branch
from
95f0794 to
024cd46
Compare
Comment on lines
+15
to
+24
| export function subscribeToFastifyErrorChannel(): void { | ||
| diagnosticsChannel.subscribe('tracing:fastify.request.handler:error', message => { | ||
| const { error, request, reply } = message as { | ||
| error: Error; | ||
| request: FastifyRequest; | ||
| reply: FastifyReply; | ||
| }; | ||
|
|
||
| handleFastifyError.call(handleFastifyError, error, request, reply, 'diagnostics-channel'); | ||
| }); |
Contributor
There was a problem hiding this comment.
Bug: The subscribeToFastifyErrorChannel function lacks an idempotency guard, allowing duplicate diagnosticsChannel subscriptions if called multiple times, which would cause duplicate error captures.
Severity: LOW
Suggested Fix
Add an internal idempotency guard to subscribeToFastifyErrorChannel. A simple boolean flag, similar to the _isInstrumented flag used in instrumentation.ts, can be used to track if the subscription has already been made and prevent re-subscribing.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
packages/server-utils/src/integrations/tracing-channel/fastify/errors.ts#L15-L24
Potential issue: The `subscribeToFastifyErrorChannel` function subscribes to Node's
`diagnosticsChannel` without an internal mechanism to prevent multiple subscriptions.
Node's `diagnosticsChannel.subscribe()` does not deduplicate handlers, so if this
function is called more than once, it will register the same handler multiple times.
While the SDK's `setupOnce()` mechanism provides protection in normal production
scenarios by using a global `installedIntegrations` array, this protection is fragile.
The function is exported (though deprecated) and could be called directly, or the global
state could be cleared (as it is in tests), leading to duplicate error captures for a
single event.
mydea
force-pushed
the
ref/streamline-fastify-otel-vendored
branch
from
8a9e626 to
9020bb5
Compare
49 tasks
andreiborza
added a commit
that referenced
this pull request
Jul 1, 2026
Re-enabled now that the streamlined fastify integration (#21706) names spans at creation instead of renaming via updateName(), so the SentryTracerProvider no longer stamps sentry.source: 'custom'. Verified locally via e2e (11/11 pass each).
andreiborza
added a commit
that referenced
this pull request
Jul 1, 2026
Re-enabled now that the streamlined fastify integration (#21706) names spans at creation instead of renaming via updateName(), so the SentryTracerProvider no longer stamps sentry.source: 'custom'. Verified locally via e2e (11/11 pass each).
andreiborza
added a commit
that referenced
this pull request
Jul 2, 2026
Re-enabled now that the streamlined fastify integration (#21706) names spans at creation instead of renaming via updateName(), so the SentryTracerProvider no longer stamps sentry.source: 'custom'. Verified locally via e2e (11/11 pass each).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of #20745, streamlining fastify v5 instrumentation:
Some other general notes:
instrumentFastifymethod and no longer calls it in preload, as this does not actually need to be preloaded anymore.