fix(bundler-plugins): integration with monorepo#21342
Conversation
Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
…ludeTracing` (#644) Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
This reverts commit 8eb6c5f.
Revert the default behaviour of the webpack plugin to no longer exit the process. Instead, users can set an experimental flag to force exiting the process.
…terUpload` (#677) Widen the accepted type for `filesToDeleteAfterSourcemaps` to allow us (as well as users) to pass in a `Promise<string | string[]>` to do so. This promise can resolve whenever we know what to set and we await the promise before calling `glob` to get all file paths to delete.
Update changelog for 3.2.0
2da5301 to
936498f
Compare
936498f to
8046230
Compare
8046230 to
4008b69
Compare
4008b69 to
1fe3d0c
Compare
1fe3d0c to
6882d3e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6882d3e. Configure here.
2420de2 to
a37151b
Compare
a37151b to
2d30000
Compare
239808f to
baf5845
Compare
|
For the new package, this list needs to be considered: I think the new package is missing |
Integrate the newly merged in `@sentry/bundler-plugins` project to the sentry-javascript monorepo. - Integration tests are updated to use the named submodule exports on the `@sentry/bundler-plugins` package, rather than the per-platform re-export shims. - Lint and naming conventions brought in line with project standards. - Bundler-plugins integration tests now run on CI. - Aligned on the same vitest version for bundler-plugins and the rest of the repo. It might be good to upgrade vitest, but not needed for this merge. The version has not been updated from its independent 5.x line, though it may be a good idea to bump it up to align with the 10.x line that the rest of the monorepo uses.
baf5845 to
cba358e
Compare
|
@timfish I copied over the LICENSE and README.md from the bundler-plugins-core package, since that's about the closest analogue to this refactor. Because it's semi-internal, I think some of the other "new SDK" steps don't really apply, but we can address them either before or after landing this, I don't really have a strong opinion about it. |

Note: the commit log in this PR is ridiculous, because it intentionally preserves the history of the sentry-javascript-bundler-plugins repo. Probably best to review locally. Attempting to do a rebase or squash merge will probably break GitHub and maybe the world 😅
Integrate the newly merged in
@sentry/bundler-pluginsproject to thesentry-javascript monorepo.
the
@sentry/bundler-pluginspackage, rather than the per-platformre-export shims.
The version has not been updated from its independent 5.x line, though
it may be a good idea to bump it up to align with the 10.x line that the
rest of the monorepo uses.