fix(hono): Allow passing env and fix type issues#19825
Merged
Conversation
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
JPeer264
approved these changes
Mar 17, 2026
| * wrapped in a Sentry span. Supports both forms: `app.use(...handlers)` and `app.use(path, ...handlers)`. | ||
| */ | ||
| export function patchAppUse(app: Hono): void { | ||
| export function patchAppUse<E extends Env>(app: Hono<E>): void { |
Member
There was a problem hiding this comment.
l: If E is never used maybe it'd be better to use the following (haven't tested it though)? It reminds me a bit of #18302
Suggested change
| export function patchAppUse<E extends Env>(app: Hono<E>): void { | |
| export function patchAppUse<H extends Hono>(app: H): void { |
Member
Author
There was a problem hiding this comment.
This would give me a massive type error :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some things in the Hono cloudflare export:
env@sentry/cloudflareCloses #19826 (added automatically)