-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(node): Add ignoreConnectSpans option to postgresIntegration
#19291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
dev-packages/node-integration-tests/suites/tracing/postgres/test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
dev-packages/node-integration-tests/suites/tracing/postgres/test.ts
Outdated
Show resolved
Hide resolved
Codecov Results 📊Generated by Codecov Action |
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
RulaKhaled
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
OTel's
PgInstrumentationexposes an option to ignorepg(.pool).connectspans.This option was added recently in open-telemetry/opentelemetry-js-contrib#3280. We should allow users to configure our wrapping
postgresIntegrationwith the same option.Usage:
Side product of looking into #19290 which turned out not to be an SDK issue . But this reminded me that we had #16536 open which we should tackle at some point. So I figured, why not now.
Docs PR: getsentry/sentry-docs#16358
closes #16536