Skip to content

fix: Dont require Vite #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timfish wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −8
Open

fix: Dont require Vite #877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f6a1e6
fix: Dont require Vite
timfish Feb 16, 2026
cc1f8ee
Add Vite to external
timfish Feb 16, 2026
871ed73
guard against missing `version` export
timfish Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite-plugin/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const extensions = [".ts"];

export default {
input,
external: [...Object.keys(packageJson.dependencies), ...modulePackage.builtinModules],
external: [...Object.keys(packageJson.dependencies), ...modulePackage.builtinModules, "vite"],
onwarn: (warning) => {
if (warning.code === "CIRCULAR_DEPENDENCY") {
// Circular dependencies are usually not a big deal for us so let's just warn about them
Expand Down
10 changes: 3 additions & 7 deletions packages/vite-plugin/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
import { SentryRollupPluginOptions } from "@sentry/rollup-plugin";
import { _rollupPluginInternal } from "@sentry/rollup-plugin";
import { createRequire } from "node:module";
import { Plugin } from "vite";
import vite, { Plugin } from "vite";

function getViteMajorVersion(): string | undefined {
try {
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore - Rollup already transpiles this for us
const req = createRequire(import.meta.url);
const vite = req("vite") as { version?: string };
return vite.version?.split(".")[0];
// The version export was only added in Vite v3?
return vite?.version?.split(".")[0];
} catch (err) {
// do nothing, we'll just not report a version
}
Expand Down
Loading