Add @Throws on SentryOkHttpInterceptor::intercept.#5654
Merged
Conversation
Contributor
Author
|
For Java, the breaking change is source‑only, easy to fix, and no binary incompatibility has been introduced. |
runningcode
approved these changes
Jun 29, 2026
runningcode
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution!
Contributor
|
@XYZboom looks like there's a changelog conflict. could you rebase? once that's done we can merge. |
Contributor
Author
Rebase is complete – branch is now clean and up‑to‑date. Ready for your review again. Please let me know if anything else is needed. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add a
@ThrowsonSentryOkHttpInterceptor::intercept.💡 Motivation and Context
Kotlin does not enforce checked exceptions, but Java does, so the @throws annotation on Kotlin methods is necessary for Java interoperability.
resolves: #5653.
resolves: JAVA-594
💚 How did you test it?
There are no logic code changes, so testing is not required.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
For Kotlin developers, this is not a breaking change, because the
@Throwsannotation on Kotlin methods does not change the signature and therefore does not affect compilation. For Java developers, this is a breaking change, because the Java method signature is modified (Java treats thrown exceptions as part of the signature).