ref!: remove Experimental from Metrics API#5023
Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Breaking Changes 🛠
Dependencies ⬆️Deps
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5023 +/- ##
==========================================
+ Coverage 73.92% 73.95% +0.02%
==========================================
Files 497 497
Lines 17974 17966 -8
Branches 3517 3516 -1
==========================================
- Hits 13287 13286 -1
+ Misses 3832 3823 -9
- Partials 855 857 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This again:
I bump into this once or twice a day... just costs time requeusting gh rerun the jobs and then coming back later to do actual reviews/approvals. It should hopefully be addressed by #4956. @Flash0ver I think we should get that merged in to check (we can always revert if it doesn't work). |
## DESCRIBE YOUR PR With the next release of the Sentry .NET SDK - expected to be `v6.3.0` - the Metrics APIs are no longer `Experimental`. This changeset updates the respective C# code snippets. Related PRs: - getsentry/sentry-dotnet#5023 - getsentry/sentry#110636 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [x] Other deadline: Release of the Sentry .NET SDK v6.3.0 - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [x] Checked Vercel preview for correctness, including links - [x] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [x] @jamescrosswell - [x] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>
## DESCRIBE YOUR PR With the next release of the Sentry .NET SDK - expected to be `v6.3.0` - the Metrics APIs are no longer `Experimental`. This changeset updates the respective C# code snippets. Related PRs: - getsentry/sentry-dotnet#5023 - getsentry/sentry#110636 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [x] Other deadline: Release of the Sentry .NET SDK v6.3.0 - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [x] Checked Vercel preview for correctness, including links - [x] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [x] @jamescrosswell - [x] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>
Summary
Remove "Experimental" properties and
[ExperimentalAttribute]from all Metrics APIs.Remarks
Changelog Entry
The Metrics APIs are now stable: removed
ExperimentalfromSentrySdk,SentryOptionsandIHubIssues
Closes #4921