feat(slo): UI display of SLO state#245
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
There was a problem hiding this comment.
Unresolved git merge conflict in config.py causes SyntaxError on startup
The file src/firetower/config.py contains unresolved git conflict markers (<<<<<<< HEAD, =======, >>>>>>> main) starting at line 80, which will cause a SyntaxError and prevent the application from starting entirely.
Evidence
grepconfirms<<<<<<< HEADis present atsrc/firetower/config.py:80.- Reading the file shows a three-way conflict block with
||||||| f7852f4and>>>>>>> mainmarkers inside theLinearConfigclass body. - Python cannot parse conflict markers as valid syntax, so any import of
firetower.configwill raiseSyntaxError. settings.pyimportsConfigFilefromfiretower.config, so Django will fail to start.- The config.example.toml hunk adds
action_item_slo_days_medium_priority = 28, which corresponds to the HEAD side of this unresolved conflict (HEAD uses28,mainuses30).
Identified by Warden code-review
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Remove duplicate LINEAR dict keys (F601) and fix prettier formatting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Agent transcript: https://claudescope.sentry.dev/share/ZK2AgPjlKdYNIFl6rOc-fi8usXZ--0tlXG8ZxqUJtZ4
…unding Serializer fallback was 28 days for medium priority but LinearConfig defaults to 30. Also fix Math.floor rounding that showed partial-day overdue items as "1d overdue" instead of "0d overdue". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Agent transcript: https://claudescope.sentry.dev/share/z531hN0j-cWcnmayYgfR23cZ3mB8ELH_d5ibE2w-Ye4
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bd25d86. Configure here.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Agent transcript: https://claudescope.sentry.dev/share/0d0EwY3qWFr-is0dzT0y3h-8iKNmu94prHn_TPHYg9U
When settings.LINEAR is None, SLO days fall back to 0 and the serializer returns null for slo_deadline. The UI already handles null deadlines by not rendering SLO labels. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Agent transcript: https://claudescope.sentry.dev/share/vusOyvEa0qawftmyz5AgtFwz9J1CStCrRVLTWbbBUzo
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Agent transcript: https://claudescope.sentry.dev/share/DEYah1TOo6H7jpeDxvPIFKEcDdtud3U5IqMKV1iiN-c
taylor-osler-sentry
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves RELENG-175
Adds displaying of the outstanding SLO times in the Firetower UI.