Skip to content

ci: Split deploy-db-migration into per-env jobs so the inactive env shows skipped #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalmurray merged 1 commit into from
Jun 5, 2026
Merged

ci: Split deploy-db-migration into per-env jobs so the inactive env shows skipped #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 27 additions & 22 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,45 +50,50 @@ jobs:
cache-from: type=gha
cache-to: type=gha,mode=max

deploy-db-migration:
deploy-db-migration-test:
needs: [build]
if: ${{ inputs.environment == 'test' }}
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5
- name: Authenticate with GCP
uses: google-github-actions/auth@7c6bc770dae815cd3e89ee6cdf493a5fab2cc093 # v3
with:
project_id: ${{ secrets.GCP_PROJECT_SLUG }}
workload_identity_provider: projects/${{ secrets.GCP_PROJECT_NUM }}/locations/global/workloadIdentityPools/github/providers/github-prvdr
- name: Run migration (test)
uses: google-github-actions/deploy-cloudrun@2028e2d7d30a78c6910e0632e48dd561b064884d # v3
with:
job: firetower-test-db-migration
project_id: ${{ secrets.GCP_PROJECT_SLUG }}
region: us-west1
image: ${{ env.BACKEND_IMAGE_REF }}
wait: true

deploy-db-migration-prod:
needs: [build]
if: ${{ github.ref == 'refs/heads/main' && ((!inputs.environment) || inputs.environment == 'prod') }}
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
include:
- env_name: test
cloud_run_job: firetower-test-db-migration
- env_name: prod
cloud_run_job: firetower-prod-db-migration
steps:
- name: Checkout code
if: >-
(matrix.env_name == 'test' && inputs.environment == 'test') ||
(matrix.env_name == 'prod' && github.ref == 'refs/heads/main' && ((!inputs.environment) || inputs.environment == 'prod'))
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5
- name: Authenticate with GCP
if: >-
(matrix.env_name == 'test' && inputs.environment == 'test') ||
(matrix.env_name == 'prod' && github.ref == 'refs/heads/main' && ((!inputs.environment) || inputs.environment == 'prod'))
uses: google-github-actions/auth@7c6bc770dae815cd3e89ee6cdf493a5fab2cc093 # v3
with:
project_id: ${{ secrets.GCP_PROJECT_SLUG }}
workload_identity_provider: projects/${{ secrets.GCP_PROJECT_NUM }}/locations/global/workloadIdentityPools/github/providers/github-prvdr
- name: Run migration (${{ matrix.env_name }})
if: >-
(matrix.env_name == 'test' && inputs.environment == 'test') ||
(matrix.env_name == 'prod' && github.ref == 'refs/heads/main' && ((!inputs.environment) || inputs.environment == 'prod'))
- name: Run migration (prod)
uses: google-github-actions/deploy-cloudrun@2028e2d7d30a78c6910e0632e48dd561b064884d # v3
with:
job: ${{ matrix.cloud_run_job }}
job: firetower-prod-db-migration
project_id: ${{ secrets.GCP_PROJECT_SLUG }}
region: us-west1
image: ${{ env.BACKEND_IMAGE_REF }}
wait: true

deploy-test:
needs: [deploy-db-migration]
needs: [deploy-db-migration-test]
if: ${{ inputs.environment == 'test' }}
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -129,7 +134,7 @@ jobs:
--container firetower-backend --image "${{ env.BACKEND_IMAGE_REF }}"

deploy-prod:
needs: [deploy-db-migration]
needs: [deploy-db-migration-prod]
if: ${{ github.ref == 'refs/heads/main' && ((!inputs.environment) || inputs.environment == 'prod') }}
runs-on: ubuntu-latest
strategy:
Expand Down
Loading