fix(ios): add missing sources - #161
Conversation
Add an opt-in CMake link test that builds a tiny executable against the Crashpad client start path. Enable it in CI, including the iOS Xcode job, so missing client implementation sources are caught by a final link.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7e787f9. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
7e787f9 to
defb093
Compare
Avoid mixing an iPhoneOS-configured Xcode project with an iPhoneSimulator build SDK, and use wmain for Windows builds that enable unicode startup.
Include the iOS crash handler implementation and shared base sources in the CMake client target so the iOS client can complete a final link.
defb093 to
dc1d183
Compare
Build the sysctl helper for all Apple util targets because the iOS system data collector uses it, and link the iOS client with the handler common library that provides CrashReportUploadThread.
|
Based on the repo history, linking has been broken on iOS since 2021-12-03. The CI missed it because it built static libraries/Xcode targets without forcing a final link against 2020-11-02: a0b37e1 added CMake iOS build support. At that point the specific missing 2021-10-14: 204abe1 added the iOS in-process handler upstream. That made 2021-12-03: 2ab34ff synced CMake files in the Sentry fork and added the iOS handler sources, but did not add the CMake equivalent of GN’s 2024-06-11: dbe6f74 merged the change where iOS began using 2025-05-14: aed4e5d split |
1 participant
#1 (comment)